New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set appropriate step property on credit inputs #604

Closed
kauffj opened this Issue Sep 22, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@kauffj
Member

kauffj commented Sep 22, 2017

Currently the step property is:

  • Inconsistent (0.1, 0.01)
  • Prevents sending or publish for small amounts.

If the step de facto enforces a minimum, it may need to be dropped entirely.

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Sep 22, 2017

Member

Don't think we have anything that enforces a minimum. There is this discussion that needs a resolution though: lbryio/lbry#768

Whatever we do, we should mention the minimum publishing amount and also alert the user to publishing fees (tx fee).

Member

tzarebczan commented Sep 22, 2017

Don't think we have anything that enforces a minimum. There is this discussion that needs a resolution though: lbryio/lbry#768

Whatever we do, we should mention the minimum publishing amount and also alert the user to publishing fees (tx fee).

@lyoshenka lyoshenka added the type: bug label Sep 26, 2017

@kauffj kauffj added this to the October 2 milestone Sep 26, 2017

kauffj added a commit that referenced this issue Sep 26, 2017

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Sep 26, 2017

Member

@tzarebczan I was wrong about this issue. The step properties are now consistent, but the input for bid on publish does not error properly for small values.

Please re-open and clean up #920 or create a new issue that articulates this clearly.

Member

kauffj commented Sep 26, 2017

@tzarebczan I was wrong about this issue. The step properties are now consistent, but the input for bid on publish does not error properly for small values.

Please re-open and clean up #920 or create a new issue that articulates this clearly.

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Sep 27, 2017

Member

The recent change made the minimum now 0.1 (previously 0.01)

Opened #628

Member

tzarebczan commented Sep 27, 2017

The recent change made the minimum now 0.1 (previously 0.01)

Opened #628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment