New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back Open File Location / way to locate downloaded file #606

Closed
tzarebczan opened this Issue Sep 22, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@tzarebczan
Member

tzarebczan commented Sep 22, 2017

The Issue

In v16, users lost the ability to open the file explorer to the location of the file. Right now they can open the file manually using Open (which opens it externally) or they can see the path in the "Downloaded to" section. So currently its difficult to locate the file because you don't even know what its called.

Maybe the solution is to add the filename to the "Downloaded to" path (need to worry about wrapping) but make it open to the file as opposed to opening the file itself? Or add another field with the filename which opens to the path?

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Sep 22, 2017

Member

If the link for "Downloaded To" is not opening the folder when clicked, this is a bug.

If it is doing that, but you were confused, then this is just poor design.

Member

kauffj commented Sep 22, 2017

If the link for "Downloaded To" is not opening the folder when clicked, this is a bug.

If it is doing that, but you were confused, then this is just poor design.

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Sep 22, 2017

Member

It opens to the folder which contains the LBRY download folder. I.e. my downloads folder is "D:\LBRY Downloads" and clicking the link goes to D:\ and highlights the LBRY Downloads folder. Not sure if that was the intention or not. The scenario I was talking about is where it highlights the particular downloaded file inside the downloads folder.

Member

tzarebczan commented Sep 22, 2017

It opens to the folder which contains the LBRY download folder. I.e. my downloads folder is "D:\LBRY Downloads" and clicking the link goes to D:\ and highlights the LBRY Downloads folder. Not sure if that was the intention or not. The scenario I was talking about is where it highlights the particular downloaded file inside the downloads folder.

@kauffj kauffj added the type: bug label Sep 22, 2017

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Sep 22, 2017

Member

This is a bug, since it is supposed to open the folder. But I think it is a UX issue too, since the intended behavior was unclear.

Member

kauffj commented Sep 22, 2017

This is a bug, since it is supposed to open the folder. But I think it is a UX issue too, since the intended behavior was unclear.

btzr-io added a commit that referenced this issue Sep 23, 2017

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Sep 23, 2017

Collaborator

Research

Fixed in #610, but you can't select (highlight) the file in linux: platform_util_linux.cc#L70

// TODO(estade): It would be nice to be able to select the file in the file
// manager, but that probably requires extending xdg-open. For now just
// show the folder.

Fix for linux

However is still possible to do this without electron.shell,
Here is a hack / workaround for electron: shell.showItemInFolder:
https://gist.github.com/btzr-io/9175cda2940bd6ee6e91555d0b8cea4b

Test

The file opens in the default File manager and gets selected:

  • Ubuntu ( it should work )
  • Debian ( it should work )
  • Fedora ( it should work )
  • Elementary OS.
Collaborator

btzr-io commented Sep 23, 2017

Research

Fixed in #610, but you can't select (highlight) the file in linux: platform_util_linux.cc#L70

// TODO(estade): It would be nice to be able to select the file in the file
// manager, but that probably requires extending xdg-open. For now just
// show the folder.

Fix for linux

However is still possible to do this without electron.shell,
Here is a hack / workaround for electron: shell.showItemInFolder:
https://gist.github.com/btzr-io/9175cda2940bd6ee6e91555d0b8cea4b

Test

The file opens in the default File manager and gets selected:

  • Ubuntu ( it should work )
  • Debian ( it should work )
  • Fedora ( it should work )
  • Elementary OS.
@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Sep 23, 2017

Collaborator

Needs more test and some confirmation / feedback to send a PR 😛

Collaborator

btzr-io commented Sep 23, 2017

Needs more test and some confirmation / feedback to send a PR 😛

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Sep 24, 2017

Collaborator

This needs to be merged first: #610

Collaborator

btzr-io commented Sep 24, 2017

This needs to be merged first: #610

@kauffj kauffj closed this in a5f65d6 Sep 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment