Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published files Sort by Title not working correctly #614

Closed
jsigwart opened this Issue Sep 25, 2017 · 2 comments

Comments

Projects
None yet
5 participants
@jsigwart
Copy link
Member

jsigwart commented Sep 25, 2017

The Issue

Published files list correctly by Date, but not by Title

Expected behavior

When I go into my Published files, I should be able to view the files alphabetically when I select the Title option.

Actual behaviour

Please see my screen shot. When I display my videos by Title, they are not in alphabetical order. I'm not sure how they're being displayed. There are two videos that start with "Betty" and then the video that starts with "A Little" is displayed between them. I thought maybe it was skipping the A, but even so, it still isn't in any kind of alphabetical order.

System Configuration

  • LBRY Daemon version: 0.16.1
  • LBRY App version: App | 0.16.0
  • LBRY Installation ID: 5eFxsAfhBFTKA5byNFVkGL5Lu5owWzQFthzKjRkxN2iUzWh2XNKLJAiv82mxAcq3AU
  • Operating system: Mac OS X 15.6.0 

Screenshots

screen shot 2017-09-24 at 10 07 38 pm

sovanna added a commit to sovanna/lbry-app that referenced this issue Oct 10, 2017

Fixes lbryio#614
Basically, the component `FileTile` displays title using
`lbryuri.parse(uri).contentName;` and not `metadata.title` cause it's
never passed to the component and `title` prop does not exist anyway
(see FileList with fileInfos object).

`.contentName` is filled with `fileInfos.name` value.

So to make all things **consistent**, we simply need to use
`fileInfo.name` in our comparaison function.
@kauffj

This comment has been minimized.

Copy link
Member

kauffj commented Oct 13, 2017

@kauffj kauffj closed this Oct 13, 2017

@kauffj kauffj reopened this Oct 13, 2017

@liamcardenas

This comment has been minimized.

Copy link
Contributor

liamcardenas commented Nov 20, 2017

@IGassmann can you take a look at this?

IGassmann pushed a commit that referenced this issue Nov 21, 2017

kauffj added a commit that referenced this issue Nov 21, 2017

Merge pull request #770 from lbryio/issue/614
Fixed sorting by title for published files (#614)

@IGassmann IGassmann closed this Nov 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.