New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better preview for content #620

Closed
btzr-io opened this Issue Sep 26, 2017 · 5 comments

Comments

Projects
None yet
6 participants
@btzr-io
Collaborator

btzr-io commented Sep 26, 2017

Update

See #620 (comment)

The Issue

The preview component seems to give priority for videos and
this affects the rest of the published content ( files ) 馃槥

Steps to reproduce

  1. Publish a content that isn't a video, audio or image.
  2. Go to the claim page and see the preview.

Expected behaviour

Support multiple preview layouts ( or a better and clean generic viewer ) for the specific content type, and display and empty state when the app can't preview the content
(non-supported videos / audio, binary files...)
See -> #551

Actual behaviour

Already explain this -> Poor ux
See the gif below...

Screenshots

really-bad-ux

Anything else

Related issue: #482 #563

btzr-io added a commit that referenced this issue Sep 26, 2017

minor css fixes
fix dark theme issues

minor css fix for #620

@btzr-io btzr-io referenced this issue Sep 26, 2017

Merged

Minor redesign #612

9 of 9 tasks complete

@btzr-io btzr-io added this to the Redesign milestone Sep 29, 2017

@btzr-io btzr-io referenced this issue Oct 2, 2017

Merged

Minor redesign (css) #647

18 of 21 tasks complete

@kauffj kauffj closed this in #647 Oct 10, 2017

@btzr-io btzr-io reopened this Oct 11, 2017

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Oct 11, 2017

Collaborator

The current preview of files sucks and has a really poor ux, but it's render-media fault 馃槢

Collaborator

btzr-io commented Oct 11, 2017

The current preview of files sucks and has a really poor ux, but it's render-media fault 馃槢

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Oct 11, 2017

Member

Render media is actually only like 350 lines of JavaScript, FWIW

Member

kauffj commented Oct 11, 2017

Render media is actually only like 350 lines of JavaScript, FWIW

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Oct 12, 2017

Collaborator

the problem is that returns an iframe, so we don't have much control on the styles 馃檭

Collaborator

btzr-io commented Oct 12, 2017

the problem is that returns an iframe, so we don't have much control on the styles 馃檭

@seanyesmunt seanyesmunt removed this from the Redesign milestone Feb 27, 2018

@LavRadis

This comment has been minimized.

Show comment
Hide comment
@LavRadis

LavRadis Mar 23, 2018

Contributor

Is it possible to have multiple preview modules for different content types? I discussed it with @btzr-io and he agrees. Maybe the dev team can add a simple one for odf, txt or pdf to enable preview of those file types. I just googled and found: http://viewerjs.org/ There are probably many more open sourced viewers that could be embedded to improve the user experience. Personally, I would like to see a 3d model preview (stl, obj) and some sort of gps data preview.

Contributor

LavRadis commented Mar 23, 2018

Is it possible to have multiple preview modules for different content types? I discussed it with @btzr-io and he agrees. Maybe the dev team can add a simple one for odf, txt or pdf to enable preview of those file types. I just googled and found: http://viewerjs.org/ There are probably many more open sourced viewers that could be embedded to improve the user experience. Personally, I would like to see a 3d model preview (stl, obj) and some sort of gps data preview.

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Mar 24, 2018

Collaborator

Possible solution would be to make a fork of render-media and integrate viewerjs as suggested by @LavRadis

Collaborator

btzr-io commented Mar 24, 2018

Possible solution would be to make a fork of render-media and integrate viewerjs as suggested by @LavRadis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment