New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction List - Categorize Rewards incoming tx #660

Closed
tzarebczan opened this Issue Oct 10, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@tzarebczan
Member

tzarebczan commented Oct 10, 2017

The Issue

Currently, incoming LBRY Rewards payments are not categorized in the transaction list. Think we should add a new category for Rewards and in details show the reward title and hyperlink to the Rewards page.

Expected behaviour

Show Rewards as "Reward"

Actual behaviour

Shows Rewards as "receive", no indication it was a reward.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@lyoshenka

This comment has been minimized.

Show comment
Hide comment
@lyoshenka

lyoshenka Oct 31, 2017

Member

@hackrush01 you connected this to #691. That PR was merged. Does that mean we can close this issue? At first glance it looks like the two are not the same.

Member

lyoshenka commented Oct 31, 2017

@hackrush01 you connected this to #691. That PR was merged. Does that mean we can close this issue? At first glance it looks like the two are not the same.

@hackrush01

This comment has been minimized.

Show comment
Hide comment
@hackrush01

hackrush01 Oct 31, 2017

Member

@lyoshenka I think this can be closed as now the rewards txns are now marked in the txn list and clicking it(the rewards description) redirects to the rewards page, which lists out all the rewards.

Member

hackrush01 commented Oct 31, 2017

@lyoshenka I think this can be closed as now the rewards txns are now marked in the txn list and clicking it(the rewards description) redirects to the rewards page, which lists out all the rewards.

@lyoshenka lyoshenka closed this Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment