New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent thumbnail sizes in 'Trending' section #721

Closed
wilsonk opened this Issue Nov 9, 2017 · 6 comments

Comments

Projects
None yet
7 participants
@wilsonk

wilsonk commented Nov 9, 2017

The Issue

One can game the trending section somewhat by using a very long channel name to make the size of the thumbnail bigger than others in that section.

Steps to reproduce

1.View trending section today (Nov 9, 2017)

Expected behaviour

All thumbnails should be the same size

Actual behaviour

Thumbnails with large channel names are larger than the rest

System Configuration

  • LBRY Daemon version: 0.17.1

  • LBRY App version:0.17.1

  • LBRY Installation ID: 26bru4Kjp3i3VM5KTFVV3ESEkDWEb9CCA2ate4L9XJYTr8PHUK4jPDQqz4JsG73Wfr

  • Operating system: Linux (Linux-4.4.0-97-generic-x86_64-with-Ubuntu-16.04-xenial)

Screenshots

screenshot_2017-11-09_11-45-19

@wilsonk

This comment has been minimized.

Show comment
Hide comment
@wilsonk

wilsonk Nov 9, 2017

Sorry, maybe that isn't the channel name being too long that is the problem, but the actual size of the file name. Perhaps that forces the 'red ship/free' icon to be pushed onto the next line which then makes the thumbnail longer not wider.

Easier to game the system this way, but with the ellipses eliding the file name size it might be easier to fix?

wilsonk commented Nov 9, 2017

Sorry, maybe that isn't the channel name being too long that is the problem, but the actual size of the file name. Perhaps that forces the 'red ship/free' icon to be pushed onto the next line which then makes the thumbnail longer not wider.

Easier to game the system this way, but with the ellipses eliding the file name size it might be easier to fix?

@wilsonk

This comment has been minimized.

Show comment
Hide comment
@wilsonk

wilsonk Nov 9, 2017

Hmm, maybe I will eventually get this right! It actually looks like a combination of both the long file name and channel name may be the problem...??

wilsonk commented Nov 9, 2017

Hmm, maybe I will eventually get this right! It actually looks like a combination of both the long file name and channel name may be the problem...??

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Nov 10, 2017

Member

I think we should remove the card design. It can be tough to deal with when trying to keep boxes the same height.

If we remove the card we could increase the visible text limit and not have to worry about different container heights. I think something like this redesign http://lab.zzk.fr/lbry/ would look really nice.

@liamcardenas thoughts?

Member

seanyesmunt commented Nov 10, 2017

I think we should remove the card design. It can be tough to deal with when trying to keep boxes the same height.

If we remove the card we could increase the visible text limit and not have to worry about different container heights. I think something like this redesign http://lab.zzk.fr/lbry/ would look really nice.

@liamcardenas thoughts?

@oakey22

This comment has been minimized.

Show comment
Hide comment
@oakey22

oakey22 Nov 10, 2017

@seanyesmunt i absolutely love that design, so professional looking

oakey22 commented Nov 10, 2017

@seanyesmunt i absolutely love that design, so professional looking

akinwale added a commit that referenced this issue Nov 14, 2017

@akinwale

This comment has been minimized.

Show comment
Hide comment
@akinwale

akinwale Nov 14, 2017

Member

Created a PR to fix this since it kept bothering me.

Also, @seanyesmunt that new design is amazing! You should show the entire team.

Member

akinwale commented Nov 14, 2017

Created a PR to fix this since it kept bothering me.

Also, @seanyesmunt that new design is amazing! You should show the entire team.

kauffj added a commit that referenced this issue Nov 15, 2017

Merge pull request #744 from lbryio/issue721
Issue #721 fix - Inconsistent thumbnail sizes
@liamcardenas

This comment has been minimized.

Show comment
Hide comment
@liamcardenas

liamcardenas Nov 20, 2017

Contributor

@tzarebczan can you verify this is working?

Contributor

liamcardenas commented Nov 20, 2017

@tzarebczan can you verify this is working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment