New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you use the scroll bar in main app screen it also moves the view in download folder and vice versa #729

Closed
LavRadis opened this Issue Nov 10, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@LavRadis
Contributor

LavRadis commented Nov 10, 2017

Working on this? See hint here

The Issue

When you scroll down in main app screen, the view in the "downloads and purchase"s is also moved when you go there. It also happens in reverse, when you move scroll in downloads view and go back to the main screen.

Steps to reproduce

  1. Move scroll down in the main screen
  2. Go to Downloads section
  3. You will notice that the view focus is not on top at last downloaded video, but it has moved down

It also works in reverse. Did not check for all app sections and views.

Expected behaviour

Moving scroll in one view should not affect other sections of the app.

Actual behaviour

You move scroll in one section, the focus moves in other also.

System Configuration

LBRY Daemon version: 0.18.0rc1
LBRY App version: 0.18.0rc1
LBRY Installation ID: 7tYN144rHXrspzJG9xLP28fi1JztXnbpKro6DBJEQyzBmXTyDgqRLfYsUvHYFVmMe2
Operating system: Win 10

Screenshots

They are attached to this issue report.

lbry view 1
lbry view 2

@LavRadis LavRadis changed the title from When you use a scroll bar in main app screen it also moves the view in download folder and vice versa to When you use the scroll bar in main app screen it also moves the view in download folder and vice versa Nov 10, 2017

@LavRadis

This comment has been minimized.

Show comment
Hide comment
@LavRadis

LavRadis Nov 10, 2017

Contributor

It also happens when you move scroll in the wallet. When you go to the main window it has also moved.

Contributor

LavRadis commented Nov 10, 2017

It also happens when you move scroll in the wallet. When you go to the main window it has also moved.

@LavRadis

This comment has been minimized.

Show comment
Hide comment
@LavRadis

LavRadis Nov 10, 2017

Contributor

It happens when you move the settings scroll bar also. Looks like all the areas of the app are affected.

Contributor

LavRadis commented Nov 10, 2017

It happens when you move the settings scroll bar also. Looks like all the areas of the app are affected.

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Nov 10, 2017

Member

Clue for whoever works on this:

You most likely to change the scrolling behavior in the doNavigate function of actions/navigation.js so that the Y position is not retained on navigation to new pages not in the history stack.

Member

kauffj commented Nov 10, 2017

Clue for whoever works on this:

You most likely to change the scrolling behavior in the doNavigate function of actions/navigation.js so that the Y position is not retained on navigation to new pages not in the history stack.

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Nov 14, 2017

Collaborator

fixed in #732

Collaborator

btzr-io commented Nov 14, 2017

fixed in #732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment