New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content address extends outside of visible area in card #741

Closed
seanyesmunt opened this Issue Nov 14, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@seanyesmunt
Member

seanyesmunt commented Nov 14, 2017

The Issue

When going to an address that is very long, content may extend passed the edge of the card

Steps to reproduce

  1. Navigate to lbry://@seanyesmunt#2fa8ecba445648eae50cb6e98948e67a417c9017/thisisaverylongstringthatiscutoff
  2. Notice content extending off the page
  3. Publish new content
  4. Go to the new content page before the publish is done, see it extend off the page

Expected behaviour

I should be able to see the entire address
Long addresses should probably wrap, maybe there is a better way, does it need to be in a card?
Since the address is in the search bar, do we need the address here?

Actual behaviour

The address is cut off

Screenshots

screen shot 2017-11-14 at 9 00 37 am

screen shot 2017-11-14 at 9 01 56 am

@amitnndn

This comment has been minimized.

Show comment
Hide comment
@amitnndn

amitnndn Jun 10, 2018

Contributor

Since this is a small fix, I am fixing this as a part of #1569 PR.

Contributor

amitnndn commented Jun 10, 2018

Since this is a small fix, I am fixing this as a part of #1569 PR.

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Jun 14, 2018

Member

Closing per #1569

Member

tzarebczan commented Jun 14, 2018

Closing per #1569

@tzarebczan tzarebczan closed this Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment