New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed LBRY URL causes app to show blank green screen #959

Closed
tzarebczan opened this Issue Jan 23, 2018 · 3 comments

Comments

Projects
None yet
7 participants
@tzarebczan
Member

tzarebczan commented Jan 23, 2018

The Issue

If a user clicks a hyperlink such as lbry://badlink, (with a comma, or possibly other characters), the LBRY app shows a blank green screen. Need to refresh the app with ctrl-shift-R to reload.

Steps to reproduce

  1. Click https://open.lbry.io/badlink%2C and open with LBRY app
  2. Notice blank green screen

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

System Configuration

  • LBRY Daemon version: 018.0
  • LBRY App version: 0.19.4
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@liamcardenas

This comment has been minimized.

Show comment
Hide comment
@liamcardenas

liamcardenas Jan 30, 2018

Contributor

@IGassmann im going to take this for grooming because i need a few more issues, feel free to work on it, though

Contributor

liamcardenas commented Jan 30, 2018

@IGassmann im going to take this for grooming because i need a few more issues, feel free to work on it, though

@miikkatu

This comment has been minimized.

Show comment
Hide comment
@miikkatu

miikkatu Feb 25, 2018

Contributor

Commenting out this bit in lbryURI.js prevents the green screen. It seems that a URL is handled correctly, the thrown exception shows in the console, but the processing stops there.

Without this bit below, a bad URL just leads to the search page with "There's nothing at this location." message.

const nameBadChars = (channelName || name).match(regexInvalidURI); if (nameBadChars) { throw new Error( __(Invalid character %s in name: %s., nameBadChars.length === 1 ? '' : 's', nameBadChars.join(', ') ) ); }

Contributor

miikkatu commented Feb 25, 2018

Commenting out this bit in lbryURI.js prevents the green screen. It seems that a URL is handled correctly, the thrown exception shows in the console, but the processing stops there.

Without this bit below, a bad URL just leads to the search page with "There's nothing at this location." message.

const nameBadChars = (channelName || name).match(regexInvalidURI); if (nameBadChars) { throw new Error( __(Invalid character %s in name: %s., nameBadChars.length === 1 ? '' : 's', nameBadChars.join(', ') ) ); }

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Feb 27, 2018

Member

Great research @miikkatu! We'd be happy to send you a tip for this. See: https://lbry.io/faq/tips

Additionally, I see you're a React dev. If you're interested in contributing more regularly, you learn more here: https://lbry.io/faq/contributing

Member

kauffj commented Feb 27, 2018

Great research @miikkatu! We'd be happy to send you a tip for this. See: https://lbry.io/faq/tips

Additionally, I see you're a React dev. If you're interested in contributing more regularly, you learn more here: https://lbry.io/faq/contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment