New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve daemon error message #1039

Merged
merged 6 commits into from Mar 2, 2018

Conversation

Projects
None yet
3 participants
@btzr-io
Collaborator

btzr-io commented Feb 22, 2018

Changes

  • Add startup-troubleshooting FAQ URL to daemon error

Preview

url_fix

fix #1027
Add startup-troubleshooting FAQ URL to daemon error

btzr-io added some commits Feb 22, 2018

add extra space
Add extra space for more clarity.
@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Feb 27, 2018

Member

Should we shorten the URL down? I can add a re-direct on lbry.io/startup if that makes it easier for someone seeing it to access.

Member

tzarebczan commented Feb 27, 2018

Should we shorten the URL down? I can add a re-direct on lbry.io/startup if that makes it easier for someone seeing it to access.

@liamcardenas

This also looks great! Please resolve merge conflict and I will merge asap.

@tzarebczan i personally think it is of a fine length, but if you want to make the short URL i can update it to match.

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Feb 28, 2018

Collaborator

@liamcardenas conflicts fixed: f6b1e80 34b5765

Collaborator

btzr-io commented Feb 28, 2018

@liamcardenas conflicts fixed: f6b1e80 34b5765

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Feb 28, 2018

Member

I'm OK with the current URL too then.

Member

tzarebczan commented Feb 28, 2018

I'm OK with the current URL too then.

btzr-io and others added some commits Feb 28, 2018

@liamcardenas liamcardenas merged commit 539dea9 into master Mar 2, 2018

1 check was pending

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details

@btzr-io btzr-io deleted the daemon_err branch Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment