New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redesign] Publish improvements #1040

Merged
merged 5 commits into from Mar 1, 2018

Conversation

Projects
None yet
3 participants
@seanyesmunt
Member

seanyesmunt commented Feb 23, 2018

LET THERE BE REDUX

Changes

Moved publish form values to redux
Move pending publish logic to redux

Issues

There are a few minor bugs but I would rather file those as existing issues and keep moving forward.

  • I am having issues with publishing under a channel but Tom can successfully do it (just my machine? I'm seeing some certificate error)
  • A few times Tom and I have seen "insufficient funds" errors from the daemon even if you have enough funds (possibly an issue with the number input or the value being coerced to a string)

Additional comments

Not super happy with the types. It feels like a lot of duplication. Additionally I'm just keeping the types in the reducer file, until Akinwale's PR to see how he goes about that.

@seanyesmunt seanyesmunt self-assigned this Feb 23, 2018

let prefillClaim;
if (id) {
prefillClaim = selectClaimById(id)(state);

This comment has been minimized.

@seanyesmunt

seanyesmunt Feb 27, 2018

Member

I think I'm probably going to change this and have whoever links to the publish page be responsible for populating the form before navigating. Currently there can be issues with this if you navigate away from the form and come back to an edit.

possibly

// file page
populatePublishForm(fileInfo);
doNavigate('/publish')
@seanyesmunt

seanyesmunt Feb 27, 2018

Member

I think I'm probably going to change this and have whoever links to the publish page be responsible for populating the form before navigating. Currently there can be issues with this if you navigate away from the form and come back to an edit.

possibly

// file page
populatePublishForm(fileInfo);
doNavigate('/publish')

This comment has been minimized.

@kauffj

kauffj Feb 27, 2018

Member

👍

@kauffj
@kauffj

As much feedback as I could give before app meeting deadline... still didn't actually run the code and didn't quite finish.

/>
<Button
alt
icon="Clipboard"

This comment has been minimized.

@kauffj

kauffj Feb 27, 2018

Member

Use constants/icons or decide we don't deem this necessary

@kauffj

kauffj Feb 27, 2018

Member

Use constants/icons or decide we don't deem this necessary

Show outdated Hide outdated src/renderer/component/common/form-components/form-field.jsx
Show outdated Hide outdated src/renderer/component/fileCard/index.js
Show outdated Hide outdated src/renderer/component/fileList/view.jsx
Show outdated Hide outdated src/renderer/component/fileList/view.jsx
Show outdated Hide outdated src/renderer/component/selectChannel/view.jsx
Show outdated Hide outdated src/renderer/component/selectChannel/view.jsx
* needed to make a dummy claim or file info object.
*/
let pendingId = 0;
function savePendingPublish({ name, channelName }) {

This comment has been minimized.

@kauffj

kauffj Feb 27, 2018

Member

👏

@kauffj
let prefillClaim;
if (id) {
prefillClaim = selectClaimById(id)(state);

This comment has been minimized.

@kauffj

kauffj Feb 27, 2018

Member

👍

@kauffj
Show outdated Hide outdated src/renderer/lbry.js

seanyesmunt added some commits Feb 27, 2018

@seanyesmunt seanyesmunt requested a review from kauffj Feb 28, 2018

@lbry-bot lbry-bot assigned kauffj and unassigned kauffj Feb 28, 2018

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Feb 28, 2018

Member

@kauffj Realized I didn't add contstants for 'anonymous' and 'new' for channel creation. And also forgot to fix the price placeholder after your comments. I'll add those.

Member

seanyesmunt commented Feb 28, 2018

@kauffj Realized I didn't add contstants for 'anonymous' and 'new' for channel creation. And also forgot to fix the price placeholder after your comments. I'll add those.

@seanyesmunt seanyesmunt merged commit 74ea22c into redesign Mar 1, 2018

2 checks passed

Linux (LBRY App) TeamCity build finished
Details
OSX (LBRY App) TeamCity build finished
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment