New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save app state when closing to tray #1042

Merged
merged 3 commits into from Feb 27, 2018

Conversation

Projects
None yet
3 participants
@IGassmann
Contributor

IGassmann commented Feb 23, 2018

No description provided.

Igor Gassmann

@IGassmann IGassmann requested a review from tzarebczan Feb 23, 2018

@lbry-bot lbry-bot assigned tzarebczan and unassigned IGassmann Feb 23, 2018

Igor Gassmann
@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Feb 27, 2018

Member

@IGassmann working as expected here, tested on Windows and Linux.

Would be nice to have a build because lbry:// hyperlinking doesn't seem to work in dev mode. Do you think that's a quick fix, I can open an issue for it.

Member

tzarebczan commented Feb 27, 2018

@IGassmann working as expected here, tested on Windows and Linux.

Would be nice to have a build because lbry:// hyperlinking doesn't seem to work in dev mode. Do you think that's a quick fix, I can open an issue for it.

@tzarebczan

Looks good from a functionality standpoint, but maybe have @seanyesmunt or @liamcardenas review the code as well.

@IGassmann

This comment has been minimized.

Show comment
Hide comment
@IGassmann

IGassmann Feb 27, 2018

Contributor

@tzarebczan it's actually expected that lbry:// deep linking URLs don't work on dev mode. Deep link URLs only work after they have been "announced" to the OS. For example on macOS, this is done with the App descriptor file Info.plist which is only generated on a packaged build and not on a dev build.

I've looked into the double-clicking for the tray icon. The feature is not yet supported on Linux: https://electronjs.org/docs/all#event-double-click-macos-windows

Contributor

IGassmann commented Feb 27, 2018

@tzarebczan it's actually expected that lbry:// deep linking URLs don't work on dev mode. Deep link URLs only work after they have been "announced" to the OS. For example on macOS, this is done with the App descriptor file Info.plist which is only generated on a packaged build and not on a dev build.

I've looked into the double-clicking for the tray icon. The feature is not yet supported on Linux: https://electronjs.org/docs/all#event-double-click-macos-windows

Igor Gassmann

@IGassmann IGassmann requested a review from seanyesmunt Feb 27, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned IGassmann Feb 27, 2018

@lbry-bot lbry-bot assigned IGassmann and unassigned seanyesmunt Feb 27, 2018

@seanyesmunt seanyesmunt merged commit b370565 into master Feb 27, 2018

2 checks passed

Linux (LBRY App) TeamCity build finished
Details
OSX (LBRY App) TeamCity build finished
Details

@seanyesmunt seanyesmunt deleted the issue/968 branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment