New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe notify #1066

Merged
merged 9 commits into from Mar 8, 2018

Conversation

Projects
None yet
4 participants
@liamcardenas
Contributor

liamcardenas commented Mar 6, 2018

This notifies users whenever their is new content available for them on a channel they have subscribed to:

  • it checks for new content
  • it notifies the user that 1 or more (up to "9+") items are available per channel
  • it starts downloading the most recent newly available video from each channel (if it is free)
  • its behavior was modeled after the iPhone podcast app

TODO: badges, I could add them into this PR, or maybe make a follow up

@liamcardenas liamcardenas requested a review from seanyesmunt Mar 6, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned liamcardenas Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 6, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 7, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 7, 2018

@lbryio lbryio deleted a comment from kauffj Mar 7, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 7, 2018

@lbryio lbryio deleted a comment from kauffj Mar 7, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 7, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 7, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 7, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 7, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 7, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 7, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 7, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 7, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 8, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 8, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 8, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 8, 2018

@@ -35,6 +36,28 @@ class FilePage extends React.PureComponent {
}
}
checkSubscriptionLatest(props) {
false
) === uri
) {
dispatch(setSubscriptionLatest(channel, uri));

@lbryio lbryio deleted a comment from codacy-bot Mar 8, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 8, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 8, 2018

const checkSubscriptionsTimer = setInterval(
() =>
selectSubscriptions(getState()).map((subscription: Subscription) =>
dispatch(doCheckSubscription(subscription))

This comment has been minimized.

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Mar 8, 2018

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 4
           

Clones removed
==============
+ src/renderer/page/file/index.js  -1
         

See the complete overview on Codacy

codacy-bot commented Mar 8, 2018

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 4
           

Clones removed
==============
+ src/renderer/page/file/index.js  -1
         

See the complete overview on Codacy

@lbryio lbryio deleted a comment from codacy-bot Mar 8, 2018

@liamcardenas liamcardenas merged commit 2342bad into master Mar 8, 2018

3 of 5 checks passed

Codacy/PR Quality Review Not so good... This pull request quality could be better.
Details
OSX (LBRY App) TeamCity build failed
Details
Linux (LBRY App) TeamCity build finished
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lyoshenka lyoshenka deleted the subscribe-notify branch Mar 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment