Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove app side balance checks #1105

Merged
merged 3 commits into from Mar 19, 2018

Conversation

Projects
None yet
4 participants
@tzarebczan
Copy link
Member

tzarebczan commented Mar 15, 2018

Adding 2 checks to channel bid (equal to balance, and equal to 0) based on #794 because the error messages don't make it from the daemon, so will these in place.

Removed publish side check, error message from the daemon are now more accurate.

Tested this out locally.

tzarebczan added some commits Mar 15, 2018

Add checks for 0 and exact balance
Otherwise, you get an ugly "internal error"
remove check for balance during publish
This is being correctly done on the daemon now and the app shows appropriate error
@seanyesmunt

This comment has been minimized.

Copy link
Member

seanyesmunt commented Mar 15, 2018

Looks good. I would just switch to === instead of ==

@lbryio lbryio deleted a comment from codacy-bot Mar 15, 2018

@@ -57,6 +57,16 @@ class ChannelSection extends React.PureComponent {

return;
}
if (newChannelBid === 0) {
this.refs.newChannelName.showError(__('Bid value must be greater than 0.'));

This comment has been minimized.

return;
}
if (newChannelBid === balance) {
this.refs.newChannelName.showError(__('Please decrease your bid to account for transaction fees.'));

This comment has been minimized.

@lbryio lbryio deleted a comment from codacy-bot Mar 15, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 15, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 15, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 15, 2018

@codacy-bot

This comment has been minimized.

Copy link

codacy-bot commented Mar 15, 2018

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 2
           

See the complete overview on Codacy

@tzarebczan

This comment has been minimized.

Copy link
Member Author

tzarebczan commented Mar 16, 2018

@seanyesmunt / @liamcardenas this can actually be merged now, doesn't need the latest daemon RC.

@liamcardenas liamcardenas merged commit 3be7f07 into master Mar 19, 2018

2 of 3 checks passed

Codacy/PR Quality Review Not so good... This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

tzarebczan added a commit that referenced this pull request Mar 19, 2018

@lyoshenka lyoshenka deleted the balance-checks branch Mar 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.