New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows notifications #1145

Merged
merged 3 commits into from Mar 20, 2018

Conversation

Projects
None yet
2 participants
@tzarebczan
Member

tzarebczan commented Mar 20, 2018

Fixes #1117 for Windows per suggestions from electron/electron#10864.

tzarebczan added some commits Mar 20, 2018

Add appID to build section
This is required to make Windows notifications work per electron/electron#10864
setAppUserModelId to io.lbry.LBRY
Required for Windows notifications per electron/electron#10864

@tzarebczan tzarebczan requested a review from IGassmann Mar 20, 2018

@IGassmann IGassmann merged commit f5a6347 into master Mar 20, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@IGassmann IGassmann deleted the windows-notif branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment