Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for the export feature #1163

Merged
merged 14 commits into from Mar 22, 2018

Conversation

Projects
None yet
5 participants
@btzr-io
Copy link
Collaborator

btzr-io commented Mar 22, 2018

Changes

  • Set default format to csv.
  • Add filters for exported data.
  • Fix issue #1157.

@btzr-io btzr-io changed the title Patch for export feature Patch for the export feature Mar 22, 2018

@btzr-io btzr-io requested a review from tzarebczan Mar 22, 2018

@lbry-bot lbry-bot assigned tzarebczan and unassigned liamcardenas Mar 22, 2018

@btzr-io btzr-io requested a review from liamcardenas Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented Mar 22, 2018

Gave it a quick test and it looked good! @IGassmann up to you if you want to merge for this release.

@@ -12,7 +12,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
* Notifications when the channel a user subscribes to uploads new content ([#1066](https://github.com/lbryio/lbry-app/pull/1066))
* Codacy support for Github contributions ([#1059](https://github.com/lbryio/lbry-app/pull/1059))
* App category for Linux ([#877](https://github.com/lbryio/lbry-app/pull/877))
* Add YouTube Sync reward ([1147](https://github.com/lbryio/lbry-app/pull/1147))
* Add YouTube Sync reward ([#1147](https://github.com/lbryio/lbry-app/pull/1147))

This comment has been minimized.

@IGassmann

IGassmann Mar 22, 2018

Contributor

Good initiative!

This comment has been minimized.

@tzarebczan

tzarebczan Mar 22, 2018

Member

That was my bad :p I'll fix up the changelog before release for others.

@IGassmann IGassmann merged commit fcdb935 into master Mar 22, 2018

0 of 3 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@IGassmann IGassmann deleted the export-data branch Mar 22, 2018

@codacy-bot

This comment has been minimized.

Copy link

codacy-bot commented Mar 22, 2018

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

See the complete overview on Codacy

@lbryio lbryio deleted a comment from codacy-bot Mar 22, 2018

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented Mar 22, 2018

Thanks for this PR @btzr-io , will send you a tip on Discord :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.