New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keyboard shortcut to quit the app on Windows #1202

Merged
merged 11 commits into from Mar 30, 2018

Conversation

Projects
None yet
3 participants
@ykris45
Contributor

ykris45 commented Mar 28, 2018

based on @IGassmann comment to my PR earlier ,

ykris45 added some commits Mar 28, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@ykris45

This comment has been minimized.

Show comment
Hide comment
@ykris45

ykris45 Mar 28, 2018

Contributor

image
image
when i press ctrl+q app closed

Contributor

ykris45 commented Mar 28, 2018

image
image
when i press ctrl+q app closed

@IGassmann

This comment has been minimized.

Show comment
Hide comment
@IGassmann

IGassmann Mar 28, 2018

Contributor

@ykris45, Please format your code with Prettier: https://github.com/lbryio/lbry-app/blob/master/CONTRIBUTING.md#code-formatting

Also, I would recommend you to use a text editor and not a word processor like WordPad to develop. A simple to use and a good one is: https://code.visualstudio.com/

Contributor

IGassmann commented Mar 28, 2018

@ykris45, Please format your code with Prettier: https://github.com/lbryio/lbry-app/blob/master/CONTRIBUTING.md#code-formatting

Also, I would recommend you to use a text editor and not a word processor like WordPad to develop. A simple to use and a good one is: https://code.visualstudio.com/

@ykris45

This comment has been minimized.

Show comment
Hide comment
@ykris45

ykris45 Mar 28, 2018

Contributor

@IGassmann that is correct bro
image

Contributor

ykris45 commented Mar 28, 2018

@IGassmann that is correct bro
image

@ykris45

This comment has been minimized.

Show comment
Hide comment
@ykris45

ykris45 Mar 28, 2018

Contributor

or i use VS Code Prettier Formatter guys

Contributor

ykris45 commented Mar 28, 2018

or i use VS Code Prettier Formatter guys

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 28, 2018

@ykris45

This comment has been minimized.

Show comment
Hide comment
@ykris45

ykris45 Mar 28, 2018

Contributor

i fixed link to this pr on changelog

Contributor

ykris45 commented Mar 28, 2018

i fixed link to this pr on changelog

@ykris45

This comment has been minimized.

Show comment
Hide comment
@ykris45

ykris45 Mar 29, 2018

Contributor

@tzarebczan done sir

Contributor

ykris45 commented Mar 29, 2018

@tzarebczan done sir

@tzarebczan tzarebczan requested a review from IGassmann Mar 30, 2018

@lbry-bot lbry-bot assigned IGassmann and unassigned liamcardenas and IGassmann Mar 30, 2018

Show outdated Hide outdated CHANGELOG.md
Show outdated Hide outdated src/main/menu/setupBarMenu.js
Show outdated Hide outdated src/main/menu/setupBarMenu.js

ykris45 added some commits Mar 30, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 30, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 30, 2018

Update CHANGELOG.md
based on igassman requested changes comment
@ykris45

This comment has been minimized.

Show comment
Hide comment
@ykris45

ykris45 Mar 30, 2018

Contributor

i think this mission completed

Contributor

ykris45 commented Mar 30, 2018

i think this mission completed

@ykris45

This comment has been minimized.

Show comment
Hide comment
@ykris45

ykris45 Mar 30, 2018

Contributor

image
LGTM @tzarebczan ...

Contributor

ykris45 commented Mar 30, 2018

image
LGTM @tzarebczan ...

@ykris45 ykris45 changed the title from alternative quit APP by click CTRL+Q to Add Menu / Keyboard shortcut to Quit the App on Windows Mar 30, 2018

Show outdated Hide outdated CHANGELOG.md

@IGassmann IGassmann changed the title from Add Menu / Keyboard shortcut to Quit the App on Windows to feat: add keyboard shortcut to quit the app on Windows Mar 30, 2018

@IGassmann IGassmann merged commit 5ba8db6 into lbryio:master Mar 30, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

IGassmann pushed a commit that referenced this pull request Apr 2, 2018

@ykris45 ykris45 deleted the ykris45:patch-1 branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment