New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black screen on macOS after maximizing LBRY and then closing #1235

Merged
merged 1 commit into from Apr 2, 2018

Conversation

Projects
None yet
4 participants
@miikkatu
Contributor

miikkatu commented Apr 1, 2018

This would close #1200.

What this does is, when closing a window, wait for a full screen window to leave full screen mode first, before actually attempting t close it.

This works on macOS, but the code has not been tested on other platforms.

@tzarebczan tzarebczan requested a review from IGassmann Apr 2, 2018

@lbry-bot lbry-bot assigned IGassmann and unassigned liamcardenas Apr 2, 2018

@IGassmann IGassmann merged commit 0ad2b3c into lbryio:master Apr 2, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Apr 3, 2018

Member

Thanks for yet another contribution @miikkatu ! Got your email for the tip, will review and follow up.

Not sure if @IGassmann tested on other OSes, but I'll make sure to give it a shot later today.

Member

tzarebczan commented Apr 3, 2018

Thanks for yet another contribution @miikkatu ! Got your email for the tip, will review and follow up.

Not sure if @IGassmann tested on other OSes, but I'll make sure to give it a shot later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment