New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-fill publish URL after clicking "Put something here" link #1303

Merged
merged 2 commits into from Apr 18, 2018

Conversation

Projects
None yet
4 participants
@miikkatu
Contributor

miikkatu commented Apr 8, 2018

This addresses #1284.

When "put something here" link is clicked, the URL here is first stripped of the lbry:// prefix, and then given as a navigation parameter. Then, the publish page uses this parameter to pre-fill the URL field in the form. Also, if the parameter exists, adding the actual file to be published will not overwrite the URL with the chosen file name.

@miikkatu miikkatu changed the title from Pre-fill publish URL to Pre-fill publish URL after clicking "Put something here" link Apr 8, 2018

@seanyesmunt seanyesmunt self-requested a review Apr 16, 2018

@miikkatu

This comment has been minimized.

Show comment
Hide comment
@miikkatu

miikkatu Apr 17, 2018

Contributor

PR updated per review!

Contributor

miikkatu commented Apr 17, 2018

PR updated per review!

@lbryio lbryio deleted a comment from codacy-bot Apr 17, 2018

@lbryio lbryio deleted a comment from codacy-bot Apr 17, 2018

@tzarebczan tzarebczan requested a review from seanyesmunt Apr 18, 2018

@seanyesmunt

Sweet 😎

I will merge after fixing the the changelog

Show outdated Hide outdated CHANGELOG.md

@lbry-bot lbry-bot assigned liamcardenas and unassigned seanyesmunt Apr 18, 2018

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Apr 18, 2018

Member

Also looks like there are some conflicts after merging the lbry-redux pr's

Member

seanyesmunt commented Apr 18, 2018

Also looks like there are some conflicts after merging the lbry-redux pr's

@miikkatu

This comment has been minimized.

Show comment
Hide comment
@miikkatu

miikkatu Apr 18, 2018

Contributor

@seanyesmunt I fixed the conflicts and removed that extra line from changelog.

Contributor

miikkatu commented Apr 18, 2018

@seanyesmunt I fixed the conflicts and removed that extra line from changelog.

@lbryio lbryio deleted a comment from codacy-bot Apr 18, 2018

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Apr 18, 2018

Member

Looks like you still have some extra stuff in the changelog

Member

seanyesmunt commented Apr 18, 2018

Looks like you still have some extra stuff in the changelog

@miikkatu

This comment has been minimized.

Show comment
Hide comment
@miikkatu

miikkatu Apr 18, 2018

Contributor

Maybe the changelog is now ok...

Contributor

miikkatu commented Apr 18, 2018

Maybe the changelog is now ok...

@lbryio lbryio deleted a comment from codacy-bot Apr 18, 2018

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Apr 18, 2018

Codacy Here is an overview of what got changed by this pull request:

Clones removed
==============
+ src/renderer/component/fileTile/index.js  -2
         

See the complete overview on Codacy

codacy-bot commented Apr 18, 2018

Codacy Here is an overview of what got changed by this pull request:

Clones removed
==============
+ src/renderer/component/fileTile/index.js  -2
         

See the complete overview on Codacy

@seanyesmunt seanyesmunt merged commit 10b6d64 into lbryio:master Apr 18, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment