New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show exact wallet balance on mouse hover over #1305

Merged
merged 2 commits into from Apr 17, 2018

Conversation

Projects
None yet
5 participants
@miikkatu
Contributor

miikkatu commented Apr 9, 2018

This implements #1259.

@seanyesmunt seanyesmunt self-requested a review Apr 16, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned liamcardenas Apr 16, 2018

@seanyesmunt

Awesome! Looks like this messed up the the balance color. The balance should always be green, and the "You have" should turn green on hover

@lbry-bot lbry-bot assigned liamcardenas and unassigned seanyesmunt Apr 16, 2018

@miikkatu

This comment has been minimized.

Show comment
Hide comment
@miikkatu

miikkatu Apr 17, 2018

Contributor

Balance color issue is now fixed!

Contributor

miikkatu commented Apr 17, 2018

Balance color issue is now fixed!

@lbryio lbryio deleted a comment from codacy-bot Apr 17, 2018

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Apr 17, 2018

Member

Sweet! Just add a changelog to this too and I will merge

Member

seanyesmunt commented Apr 17, 2018

Sweet! Just add a changelog to this too and I will merge

@miikkatu

This comment has been minimized.

Show comment
Hide comment
@miikkatu

miikkatu Apr 17, 2018

Contributor

Changelog updated.

Contributor

miikkatu commented Apr 17, 2018

Changelog updated.

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Apr 17, 2018

Codacy Here is an overview of what got changed by this pull request:

Clones removed
==============
+ src/renderer/component/header/index.js  -2
         

See the complete overview on Codacy

codacy-bot commented Apr 17, 2018

Codacy Here is an overview of what got changed by this pull request:

Clones removed
==============
+ src/renderer/component/header/index.js  -2
         

See the complete overview on Codacy

@lbryio lbryio deleted a comment from codacy-bot Apr 17, 2018

@seanyesmunt seanyesmunt merged commit f21061e into lbryio:master Apr 17, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@miikkatu miikkatu deleted the miikkatu:show-exact-balance-on-hover branch Apr 17, 2018

@miikkatu miikkatu restored the miikkatu:show-exact-balance-on-hover branch Apr 17, 2018

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Apr 17, 2018

Member

Thanks @miikkatu! Have your contribution email, will follow up soon!

Member

tzarebczan commented Apr 17, 2018

Thanks @miikkatu! Have your contribution email, will follow up soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment