New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flair to snackbar #1313

Merged
merged 2 commits into from Apr 17, 2018

Conversation

Projects
None yet
4 participants
@miikkatu
Contributor

miikkatu commented Apr 10, 2018

This is for #1279.

screen shot 2018-04-10 at 14 06 56

Unlike modal dialogs in the redesign, this is with a dark background to make it pop a bit more. Functionality remains the same as with the original snackbar.

The prop-types package was added as a dependency.

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Apr 12, 2018

Member

Nice. I will check out the code more later but the picture looks good. We are using flow instead of prop-types so your types should be moved to that.

Member

seanyesmunt commented Apr 12, 2018

Nice. I will check out the code more later but the picture looks good. We are using flow instead of prop-types so your types should be moved to that.

@miikkatu

This comment has been minimized.

Show comment
Hide comment
@miikkatu

miikkatu Apr 12, 2018

Contributor

@seanyesmunt I updated the code as suggested in the comments.

Contributor

miikkatu commented Apr 12, 2018

@seanyesmunt I updated the code as suggested in the comments.

@miikkatu

This comment has been minimized.

Show comment
Hide comment
@miikkatu

miikkatu Apr 17, 2018

Contributor

PR changed per review. Also, snack-bar__action was moved to the top level along with snack-bar__message.

Contributor

miikkatu commented Apr 17, 2018

PR changed per review. Also, snack-bar__action was moved to the top level along with snack-bar__message.

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Apr 17, 2018

Member

Awesome! Just add a changelog commit and I will merge

Member

seanyesmunt commented Apr 17, 2018

Awesome! Just add a changelog commit and I will merge

@miikkatu

This comment has been minimized.

Show comment
Hide comment
@miikkatu

miikkatu Apr 17, 2018

Contributor

Changelog updated.

Contributor

miikkatu commented Apr 17, 2018

Changelog updated.

@seanyesmunt seanyesmunt merged commit dad29b7 into lbryio:master Apr 17, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Apr 17, 2018

Member

Thanks @miikkatu! Have your contribution email, will follow up soon!

Member

tzarebczan commented Apr 17, 2018

Thanks @miikkatu! Have your contribution email, will follow up soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment