New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report infringing content within app #1425
Report infringing content within app #1425
Conversation
Generated by 🚫 dangerJS |
This is looking good, a couple comments. Most of this should live in redux. We shouldn't be making api calls in in the component to keep things simple. You should also avoid mixing props and internal state like you are doing in this line: I propose creating a |
I think in this case setting the state from props is ok, because it's like seed data. The form is generic so that the identifier can be uri but also something else as the UI info text says (Name, claim ID, or another way for us to identify the infringing content.). This reporting function should eventually be generic, so that it could also be opened from sidebar. And when it's opened from there, the uri param will not be in the props, and the form will set the field as empty. |
Looks like this would require more time than I currently have, unfortunately. Hopefully someone else can continue from here. |
closing, looking at a new direction/solution |
@miikkatu We may come back to this. I will re-open if we decide to go with this solution. |
This is a suggested implementation for #909.
This is work-in-progress, as there is a CORS issue when posting the report, as discussed with @maximest-pierre.