New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards reorder and snackbar notifications #1509

Merged
merged 8 commits into from May 31, 2018

Conversation

Projects
None yet
4 participants
@daovist
Collaborator

daovist commented May 23, 2018

Refactor unclaimed rewards as array to keep order from api.lbry.io. Display reward notification message through snackbar with fallback for rewards with no message.

#1329

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan May 24, 2018

Member

@daovist we should clean up: https://github.com/lbryio/lbry-app/blob/master/src/renderer/rewards.js right? Since it's no longer considering those types and reward messages.

Member

tzarebczan commented May 24, 2018

@daovist we should clean up: https://github.com/lbryio/lbry-app/blob/master/src/renderer/rewards.js right? Since it's no longer considering those types and reward messages.

@daovist

This comment has been minimized.

Show comment
Hide comment
@daovist

daovist May 24, 2018

Collaborator

@tzarebczan as I cleaned up rewards.js I realized I was duplicating the reward notification so that is fixed now too

Collaborator

daovist commented May 24, 2018

@tzarebczan as I cleaned up rewards.js I realized I was duplicating the reward notification so that is fixed now too

@seanyesmunt

Should we move the claimedRewards over to an array to be consistent? Not really sure.

Show outdated Hide outdated src/renderer/redux/actions/rewards.js
@daovist

I don't think it matters much if we refactor claimedRewards but am happy to do so

Show outdated Hide outdated src/renderer/redux/actions/rewards.js
@skhameneh

Minor comment

Show outdated Hide outdated src/renderer/redux/reducers/rewards.js

@lbry-bot lbry-bot assigned seanyesmunt and unassigned skhameneh May 29, 2018

Refactor unclaimed rewards as array to keep order from api.lbry.io. D…
…isplay reward notification message through snackbar with fallback for rewards without a message.
@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan May 29, 2018

Member

Giving this a test with the new user reward.

Member

tzarebczan commented May 29, 2018

Giving this a test with the new user reward.

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan May 30, 2018

Member

The last cleanup of rewards.js broke reward.type constant comparisons which breaks first reward modal and ability to claim rewards like publish / channel. Travis looking into it.

Member

tzarebczan commented May 30, 2018

The last cleanup of rewards.js broke reward.type constant comparisons which breaks first reward modal and ability to claim rewards like publish / channel. Travis looking into it.

daovist and others added some commits May 30, 2018

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan May 31, 2018

Member

This is working as expected again. @seanyesmunt we also removed the amount from the invite button because it was coming back as 0. It may be misleading also, because sending the invite doesn't actually get you 3 credits (the person has to sign up, get approved, etc), so I think it's better this way.

Member

tzarebczan commented May 31, 2018

This is working as expected again. @seanyesmunt we also removed the amount from the invite button because it was coming back as 0. It may be misleading also, because sending the invite doesn't actually get you 3 credits (the person has to sign up, get approved, etc), so I think it's better this way.

seanyesmunt added some commits May 31, 2018

@seanyesmunt seanyesmunt merged commit d65d92e into master May 31, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@seanyesmunt seanyesmunt deleted the issue/1329 branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment