Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation propmt before sending a transaction. #1525

Merged
merged 3 commits into from Jun 1, 2018

Conversation

Projects
None yet
3 participants
@dan1d
Copy link
Contributor

dan1d commented May 28, 2018

Closes #947
It adds the feature to prompt a modal before sending a transaction.
Maybe we can add the usd value of the transaction also?

screenshot from 2018-05-28 17-01-57
screenshot from 2018-05-28 17-02-14

@seanyesmunt

This comment has been minimized.

Copy link
Member

seanyesmunt commented May 30, 2018

This is awesome. I think if we say "Once the transaction is sent, it cannot be reversed." it would be a little more clear.

@seanyesmunt
Copy link
Member

seanyesmunt left a comment

Just the copy change. Nice work

@dan1d

This comment has been minimized.

Copy link
Contributor Author

dan1d commented May 30, 2018

@seanyesmunt Thanks, I've updated the requested text change.

@seanyesmunt seanyesmunt force-pushed the dan1d:issue-947 branch from 3f70c3c to 38fbc19 Jun 1, 2018

@seanyesmunt seanyesmunt merged commit 5ca1124 into lbryio:master Jun 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.