Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix claim ID being null when reporting a claim that was not previously download. #1530

Merged
merged 3 commits into from Jun 1, 2018

Conversation

Projects
None yet
3 participants
@DaniNz
Copy link
Contributor

DaniNz commented May 31, 2018

Closes issue: #1512 properly pass claim ID to the https://lbry.io/dmca?claim_id url, as @tzarebczan told me I will continue to work on #1425 but for now the fix closes #1512

@DaniNz DaniNz changed the title Fix claim ID on when reporting a claim. Fix claim ID being null when reporting a claim that was not previously download. May 31, 2018

@seanyesmunt
Copy link
Member

seanyesmunt left a comment

Just one small change but looks great. Thanks!

@@ -12,6 +12,7 @@ const select = (state, props) => ({
/* availability check is disabled due to poor performance, TBD if it dies forever or requires daemon fix */
costInfo: makeSelectCostInfoForUri(props.uri)(state),
claimIsMine: makeSelectClaimIsMine(props.uri)(state),
claimId: props.claimId,

This comment has been minimized.

@seanyesmunt

seanyesmunt May 31, 2018

Member

Since this is already being passed in from another component, we don't need to specify it here. This is only for selecting props from state.

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented May 31, 2018

Woohoo @DaniNz, thanks for the contribution - glad you made it through your first PR! Normally we have a bot that reminds devs about updating the changelog, but it's disabled at the moment. Can you please do so at your earliest convenience? See previous entries for format...it's pretty straightforward.

If you are interested in an LBC tip for your time, please see https://lbry.io/faq/tips

We'll also be adding you to our developer mailing list so we can keep in touch (you can unsubscribe anytime!).

DaniNz added some commits Jun 1, 2018

@DaniNz

This comment has been minimized.

Copy link
Contributor Author

DaniNz commented Jun 1, 2018

Thanks @seanyesmunt for the review, i have updated the code as you requested.
Also thanks @tzarebczan i'm very happy with my first PR. I will send an email soon for the tip.

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jun 1, 2018

@seanyesmunt seanyesmunt merged commit 185fba7 into lbryio:master Jun 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.