New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileRender component #1576

Merged
merged 16 commits into from Jul 10, 2018

Conversation

Projects
None yet
3 participants
@btzr-io
Collaborator

btzr-io commented Jun 11, 2018

Changes

  • Fix Review isPlayable() function #1590
  • Use router pattern for rendering file viewer #1544
  • Initial step for #620
  • Add pdf-viewer to actually test something. #1701

Todo

  • Improve file type detection.
  • Fix getMediaType logic lbryio/lbry-redux#51
  • Rename: video -> FileViewer

@btzr-io btzr-io requested a review from seanyesmunt Jun 22, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned kauffj Jun 22, 2018

@seanyesmunt seanyesmunt referenced this pull request Jun 27, 2018

Merged

Add 3D-file-viewer component #1558

11 of 12 tasks complete
@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Jun 27, 2018

Collaborator

Initial step for #620

Collaborator

btzr-io commented Jun 27, 2018

Initial step for #620

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jun 28, 2018

@seanyesmunt

Left a few more comments, not sure if all of them warrant changes.

Tom and I will be doing more testing on this tomorrow, with a lot of file types. Should be able to get it merged in the next day or two. Great work!

@btzr-io btzr-io referenced this pull request Jul 4, 2018

Merged

Fix getMediaType logic #51

@btzr-io btzr-io added the on hold label Jul 5, 2018

@btzr-io btzr-io requested a review from seanyesmunt Jul 10, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jul 10, 2018

@btzr-io btzr-io removed the on hold label Jul 10, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jul 10, 2018

@seanyesmunt seanyesmunt merged commit e317f57 into master Jul 10, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@btzr-io btzr-io deleted the file-preview branch Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment