Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add togglable QR code to wallet address component #1582

Merged
merged 2 commits into from Jun 14, 2018

Conversation

Projects
None yet
3 participants
@daovist
Copy link
Contributor

daovist commented Jun 12, 2018

No description provided.

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented Jun 12, 2018

I'm not crazy about how the button looks on both light and dark themes. Maybe @seanyesmunt can work on styling it better.

Also, doesn't work in dark mode - looks like some of the background is seeping through and adding some extra tiny lines to the QR.
qr code

@seanyesmunt

This comment has been minimized.

Copy link
Member

seanyesmunt commented Jun 12, 2018

I agree @tzarebczan. There was some styling to ensure the qr code had a white border so that it worked with dark mode. Maybe we lost that? This should probably use the button="link" style.

@daovist daovist force-pushed the qr-code branch from 4107022 to 596ad0f Jun 12, 2018

@daovist

This comment has been minimized.

Copy link
Contributor Author

daovist commented Jun 12, 2018

updated to button="link"

@daovist daovist force-pushed the qr-code branch from 596ad0f to 37e39f4 Jun 13, 2018

@seanyesmunt seanyesmunt self-requested a review Jun 13, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jun 13, 2018

@seanyesmunt
Copy link
Member

seanyesmunt left a comment

screen shot 2018-06-13 at 12 33 31 pm

Seeing this with the error

Failed prop type: Invalid prop `size` of type `string` supplied to `QRCodeCanvas`, expected `number`.
in QRCodeCanvas (created by QRCode)

Not sure why it's overlapping. I also think we can make this a little bit smaller.

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jun 13, 2018

@daovist daovist force-pushed the qr-code branch from 37e39f4 to f6ed24a Jun 13, 2018

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented Jun 14, 2018

Working on dark mode now!

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jun 14, 2018

@seanyesmunt seanyesmunt merged commit f84242b into master Jun 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@seanyesmunt seanyesmunt deleted the qr-code branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.