Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tourniquets Text Over 20VW to Fix Table Length Issue #1692

Merged
merged 3 commits into from Jun 27, 2018

Conversation

Projects
None yet
2 participants
@Invariant-Change
Copy link
Contributor

Invariant-Change commented Jun 26, 2018

Fixes table length issue #1690

BEFORE

image

AFTER

image

VW Fixes Responsive Issues
Using 400px still breaks if at minimum width. However, using Viewport Width (vw) makes it responsive, thus it works at all sizes without out the need for condition media queries.

@Invariant-Change Invariant-Change changed the title Tourniquets Text Over 400px to Fix Table Length Issue Tourniquets Text Over 20VH to Fix Table Length Issue Jun 26, 2018

Over VW Comment Change
Over VW Comment Change

@Invariant-Change Invariant-Change changed the title Tourniquets Text Over 20VH to Fix Table Length Issue Tourniquets Text Over 20VW to Fix Table Length Issue Jun 26, 2018

@Invariant-Change

This comment has been minimized.

Copy link
Contributor Author

Invariant-Change commented Jun 26, 2018

Using Viewport Width (vw) makes it responsive, thus it works at all sizes without out the need for conditional media queries.

Invariant-Change added a commit to Invariant-Change/lbry-app that referenced this pull request Jun 26, 2018

@seanyesmunt

This comment has been minimized.

Copy link
Member

seanyesmunt commented Jun 27, 2018

This is great.

@seanyesmunt seanyesmunt merged commit f0f9894 into lbryio:master Jun 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Invariant-Change Invariant-Change deleted the Invariant-Change:patch-1 branch Jun 27, 2018

@Invariant-Change

This comment has been minimized.

Copy link
Contributor Author

Invariant-Change commented Jun 27, 2018

Thanks @seanyesmunt I was looking for it to auto tourniquet based on the current %width, but it would only work with a set VW (viewport width).

I will spend more time on this at a later date and play around with things like converting the current table % values to VW to see if that is a better solution that will be globally acceptable for any sized area, which I think was @kauffj's concern.

For now, these are a good fix with the current layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.