New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tourniquets Text to Fix Table Length Issue in Help #1694

Merged
merged 2 commits into from Jun 27, 2018

Conversation

Projects
None yet
3 participants
@Invariant-Change
Contributor

Invariant-Change commented Jun 26, 2018

Same CSS issue and fix as #1692 which fixes tables issues when the app is at minimum width.

These little details help keep the app looking professional, thus helping brand reputation/authority.

BEFORE

image

AFTER

image

@Invariant-Change Invariant-Change changed the title from Tourniquets Text Over 20VW to Fix Table Length Issue in Help to Tourniquets Text to Fix Table Length Issue in Help Jun 26, 2018

Only Affects Help Table
table.table--help {
  td:nth-of-type(1) {
    color: var(--text-color);
    font-family: 'metropolis-semibold';
    min-width: 130px;
  }
    td:nth-of-type(2) {
/*Tourniquets text over 20VW*/
    max-width: 20vw;
    overflow: hidden;
    white-space: nowrap;
    text-overflow: ellipsis;
  }
}
@Invariant-Change

This comment has been minimized.

Show comment
Hide comment
@Invariant-Change

Invariant-Change Jun 26, 2018

Contributor

Was better placed in the HELP section of the CSS. This way, it's only affecting the HELP table and not global assets.

table.table--help {
  td:nth-of-type(1) {
    color: var(--text-color);
    font-family: 'metropolis-semibold';
    min-width: 130px;
  }
    td:nth-of-type(2) {
/*Tourniquets text over 20VW*/
    max-width: 20vw;
    overflow: hidden;
    white-space: nowrap;
    text-overflow: ellipsis;
  }
}
Contributor

Invariant-Change commented Jun 26, 2018

Was better placed in the HELP section of the CSS. This way, it's only affecting the HELP table and not global assets.

table.table--help {
  td:nth-of-type(1) {
    color: var(--text-color);
    font-family: 'metropolis-semibold';
    min-width: 130px;
  }
    td:nth-of-type(2) {
/*Tourniquets text over 20VW*/
    max-width: 20vw;
    overflow: hidden;
    white-space: nowrap;
    text-overflow: ellipsis;
  }
}

@seanyesmunt seanyesmunt merged commit 7f60b53 into lbryio:master Jun 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Invariant-Change Invariant-Change deleted the Invariant-Change:patch-3 branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment