Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish fixes #1716

Merged
merged 6 commits into from Jul 2, 2018

Conversation

Projects
None yet
3 participants
@seanyesmunt
Copy link
Member

seanyesmunt commented Jun 28, 2018

Fixes

Disabled the file input when publishing === true
Fix an issue with form error styling at the bottom of the publish form
#1714
#1647

Moved button styling to be specific to the transactions table because it was affecting buttons it shouldn't.

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented Jul 2, 2018

Tested and working as expected for me. When I edit the name, I get the warning about selecting a file. Publish works after going down that route. Also able to change the name back and edit as expected.

@tzarebczan tzarebczan requested a review from kauffj Jul 2, 2018

@lbry-bot lbry-bot assigned kauffj and unassigned seanyesmunt Jul 2, 2018

@kauffj
Copy link
Member

kauffj left a comment

I would like the application of the tourniquitting CSS to be improved and then you can merge this without another review.

{!bid && <div>{__('A bid amount is required')}</div>}
{!tosAccepted && <div>{__('You must agree to the terms of service')}</div>}
</div>
!isFormValid && (

This comment has been minimized.

@kauffj

kauffj Jul 2, 2018

Member

This is fine, but it's worth considering in the future how at least some of these could be funneled directly to the fields rather than all shown in a global area.

This comment has been minimized.

@seanyesmunt

seanyesmunt Jul 2, 2018

Author Member

They are shown in the field, this is just extra help at the bottom of the page so it isn't confusing why the publish button is greyed out.

This comment has been minimized.

@kauffj

kauffj Jul 2, 2018

Member

👍

This comment has been minimized.

@kauffj

kauffj Jul 2, 2018

Member

(On second thought, this still feels somewhat wrong. Maybe the superior pattern is one that provides a link to scroll to the fields with errors? But obviously non-blocking)

This comment has been minimized.

@seanyesmunt

seanyesmunt Jul 2, 2018

Author Member

I like that idea 👍

@@ -99,6 +99,15 @@ table.table--transactions {
}
td:nth-of-type(3) {
width: 22.5%;

.btn--link {

This comment has been minimized.

@kauffj

kauffj Jul 2, 2018

Member

I like this tourniquitting CSS but I dislike how it is being applied. Is tourniqueting text really just a property of button links when they're inside the 3rd td element of a <table.table--help>? This seems unlikely.

If we're struggling to find a clear global rule for these, I think it makes more sense to apply turniquitting as either a table or cell level class property.

This comment has been minimized.

@kauffj

kauffj Jul 2, 2018

Member

Also, this breaks BEM

@lbry-bot lbry-bot assigned seanyesmunt and unassigned kauffj Jul 2, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jul 2, 2018

@seanyesmunt seanyesmunt force-pushed the publish-fixes branch from 039badd to adaec74 Jul 2, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jul 2, 2018

@seanyesmunt seanyesmunt merged commit 9a8d487 into master Jul 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@seanyesmunt seanyesmunt deleted the publish-fixes branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.