Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take previous bid into account for total available to deposit #1725

Merged
merged 2 commits into from Jul 2, 2018

Conversation

Projects
None yet
2 participants
@seanyesmunt
Copy link
Member

seanyesmunt commented Jul 2, 2018

@seanyesmunt seanyesmunt requested a review from kauffj Jul 2, 2018

@lbry-bot lbry-bot assigned kauffj and unassigned seanyesmunt Jul 2, 2018

@kauffj

kauffj approved these changes Jul 2, 2018

previousBidAmount = myClaimForUri.amount;
}

const totalAvailableBidAmount = previousBidAmount + balance;

This comment has been minimized.

@kauffj

kauffj Jul 2, 2018

Member

This logic would conceivably be better placed in a selector, but otherwise LGTM

@lbry-bot lbry-bot assigned seanyesmunt and unassigned kauffj Jul 2, 2018

@seanyesmunt seanyesmunt merged commit 9305548 into master Jul 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@seanyesmunt seanyesmunt deleted the 1712 branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.