New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually hide NSFW content #1748

Merged
merged 8 commits into from Jul 13, 2018

Conversation

Projects
None yet
3 participants
@seanyesmunt
Member

seanyesmunt commented Jul 10, 2018

Dependent upon lbryio/lbry-redux#53

Currently causes issues with the community top bids section. That will be fixed in a future PR.

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Jul 12, 2018

Member

This LGTM on the channel and search pages. Gave @seanyesmunt a heads up about subs page - if you are subbed to a channel that has NSFW (and have NSFW off), there's no indication on the sub page that they are hidden.

Member

tzarebczan commented Jul 12, 2018

This LGTM on the channel and search pages. Gave @seanyesmunt a heads up about subs page - if you are subbed to a channel that has NSFW (and have NSFW off), there's no indication on the sub page that they are hidden.

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Jul 12, 2018

Member

Actually, found an edge case when my own content is marked as NSFW and going to the channel page - says result is hidden, but it's not. We should not hide it if it's our own content, right? So just need to suppress the message.
https://www.screencast.com/t/vmUvZLTkuPv

Member

tzarebczan commented Jul 12, 2018

Actually, found an edge case when my own content is marked as NSFW and going to the channel page - says result is hidden, but it's not. We should not hide it if it's our own content, right? So just need to suppress the message.
https://www.screencast.com/t/vmUvZLTkuPv

@seanyesmunt seanyesmunt merged commit da9eb3d into master Jul 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@seanyesmunt seanyesmunt deleted the hide-nsfw branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment