New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel page caching #1750

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
2 participants
@daovist
Collaborator

daovist commented Jul 10, 2018

Issue #1255

Moves <BusyIndicator> to title bar.

Refactors contentList to show "No content found" only after fetch is complete; null while fetching.

channel page fetching

There is still some chance that a user will click the wrong tile but the update is very fast and pretty smooth. The best way I see to prevent this is to disable navigation for ~1sec following the update. This could be done by adding a throttle property to the state along with corresponding actions, reducers, and a thunk in doNavigate, or migrating from thunks to middleware, both of which seem well beyond the scope of this issue.

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jul 10, 2018

@seanyesmunt

Two very small changes.

Show outdated Hide outdated src/renderer/page/channel/view.jsx
Show outdated Hide outdated src/renderer/page/channel/view.jsx
@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Jul 11, 2018

Member

This is great. So much smoother.

Member

seanyesmunt commented Jul 11, 2018

This is great. So much smoother.

@daovist

This comment has been minimized.

Show comment
Hide comment
@daovist

daovist Jul 11, 2018

Collaborator

I also cleaned up types in <BusyIndicator>.

Collaborator

daovist commented Jul 11, 2018

I also cleaned up types in <BusyIndicator>.

@seanyesmunt seanyesmunt merged commit 14dc5dd into master Jul 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@seanyesmunt seanyesmunt deleted the channel-caching branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment