New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate thumbnails #1755

Merged
merged 6 commits into from Jul 19, 2018

Conversation

Projects
None yet
5 participants
@daovist
Collaborator

daovist commented Jul 11, 2018

#1362

Inform the user whether their manually entered thumbnail URL is valid and display a preview of it.

I mostly forgot how to do CSS after Bootstrap came out and most of my early website gigs were pixel-to-HTML so my design skills are severely lacking. This will probably need some input/touchup from others.

manual thumbnail preview

@daovist daovist requested a review from seanyesmunt Jul 11, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned lyoshenka Jul 11, 2018

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Jul 11, 2018

Member

Great idea! (Agreed UI should likely change a bit)

Member

kauffj commented Jul 11, 2018

Great idea! (Agreed UI should likely change a bit)

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Jul 12, 2018

Member

This is awesome. Will think about how we can display this in the app.

Member

seanyesmunt commented Jul 12, 2018

This is awesome. Will think about how we can display this in the app.

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Jul 18, 2018

Member

Current design:

  • Manual mode with no/invalid thumbnail

screen shot 2018-07-18 at 11 56 20 am

  • Manual mode with valid thumbnail

screen shot 2018-07-18 at 11 53 45 am

  • Upload thumbnail complete

screen shot 2018-07-18 at 12 00 11 pm

Member

seanyesmunt commented Jul 18, 2018

Current design:

  • Manual mode with no/invalid thumbnail

screen shot 2018-07-18 at 11 56 20 am

  • Manual mode with valid thumbnail

screen shot 2018-07-18 at 11 53 45 am

  • Upload thumbnail complete

screen shot 2018-07-18 at 12 00 11 pm

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Jul 18, 2018

Member

I think the only thing left would be to create a proper "No thumbnail chosen" (or whatever we want to call it) image to use instead of the quick one I added.

Member

seanyesmunt commented Jul 18, 2018

I think the only thing left would be to create a proper "No thumbnail chosen" (or whatever we want to call it) image to use instead of the quick one I added.

@seanyesmunt seanyesmunt removed their request for review Jul 18, 2018

@lbry-bot lbry-bot assigned skhameneh and unassigned seanyesmunt Jul 18, 2018

@seanyesmunt seanyesmunt merged commit 1d9282e into master Jul 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@seanyesmunt seanyesmunt deleted the verify-thumbnail-url branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment