New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide community row if nsfw content is hidden #1760

Merged
merged 2 commits into from Jul 12, 2018

Conversation

Projects
None yet
3 participants
@seanyesmunt
Member

seanyesmunt commented Jul 12, 2018

I think we should keep the "row" styling somewhat there. Then users know this would be a scrollable row just like the other rows, if they change their settings.

screen shot 2018-07-11 at 9 54 28 pm

@@ -21,7 +21,6 @@
}
.card--small {
width: var(--card-small-width);

This comment has been minimized.

@seanyesmunt

seanyesmunt Jul 12, 2018

Member

this wasn't doing anything.

@seanyesmunt

seanyesmunt Jul 12, 2018

Member

this wasn't doing anything.

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jul 12, 2018

@@ -1,11 +1,11 @@
// @flow
import React from 'react';
import * as React from 'react';

This comment has been minimized.

@skhameneh

skhameneh Jul 12, 2018

Member

why this change?

@skhameneh

skhameneh Jul 12, 2018

Member

why this change?

This comment has been minimized.

@seanyesmunt

seanyesmunt Jul 12, 2018

Member

It's needed after adding React.Fragment. Flow acts funny without it.

@seanyesmunt

seanyesmunt Jul 12, 2018

Member

It's needed after adding React.Fragment. Flow acts funny without it.

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Jul 12, 2018

@seanyesmunt seanyesmunt requested a review from tzarebczan Jul 12, 2018

@lbry-bot lbry-bot assigned tzarebczan and unassigned seanyesmunt Jul 12, 2018

@seanyesmunt seanyesmunt removed the request for review from tzarebczan Jul 12, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned tzarebczan Jul 12, 2018

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Jul 12, 2018

Member

This looks good to me and confirmed with Rob that will move trending to top (or 2nd from top) so that Community top bids will be at the bottom. This means we won't have to worry about the weird spacing.

Member

tzarebczan commented Jul 12, 2018

This looks good to me and confirmed with Rob that will move trending to top (or 2nd from top) so that Community top bids will be at the bottom. This means we won't have to worry about the weird spacing.

@seanyesmunt seanyesmunt merged commit aea3816 into master Jul 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@seanyesmunt seanyesmunt deleted the nsfw-community branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment