New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress load video error #1768

Merged
merged 6 commits into from Jul 19, 2018

Conversation

Projects
None yet
4 participants
@daovist
Collaborator

daovist commented Jul 13, 2018

#1612

Depends on /lbryio/lbry-redux/issues/57

Refactor video loading error into a single function handleLoadVideoError and use for timeout and catch.

Suppress error notification when the user is playing another video. We could also suppress the error when no video is playing?

This fix introduced an issue with autoplay where it keeps trying again after it fails and stacks error messages. I added (in 'lbry-redux) an error property to fileInfo. When a video fails to load the uri is added to the error object with value true. If this value is true for a given uri, that media will not autoplay. This value is deleted when the video starts to load/play again.

@daovist daovist requested a review from seanyesmunt Jul 13, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned skhameneh Jul 13, 2018

@seanyesmunt seanyesmunt assigned daovist and unassigned seanyesmunt Jul 18, 2018

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Jul 18, 2018

Member

This issue/solution might highlight that what the app really needs is an error/notification queue (e.g. something like the one on GitHub).

(This is separate from the PR, which would still be an approvement over the status quo.)

Member

kauffj commented Jul 18, 2018

This issue/solution might highlight that what the app really needs is an error/notification queue (e.g. something like the one on GitHub).

(This is separate from the PR, which would still be an approvement over the status quo.)

@seanyesmunt seanyesmunt merged commit 863a95b into master Jul 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@seanyesmunt seanyesmunt deleted the suppress-load-video-error branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment