Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic wallet encryption flows #1785

Merged
merged 6 commits into from Jul 25, 2018

Conversation

Projects
None yet
2 participants
@skhameneh
Copy link
Member

skhameneh commented Jul 18, 2018

Shawn Khameneh Shawn Khameneh

@skhameneh skhameneh requested a review from seanyesmunt Jul 18, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned skhameneh Jul 18, 2018

@seanyesmunt
Copy link
Member

seanyesmunt left a comment

Very very minor styling issue and a question.

onChange={event => this.onChangePassword(event)}
/>
</FormRow>
<FormRow padded>

This comment has been minimized.

@seanyesmunt

seanyesmunt Jul 20, 2018

Member

Instead of using FormRow, use <div className="card__actions"><Button />...

onChange={event => this.onChangeUnderstandConfirm(event)}
/>
</FormRow>
<FormRow padded>

This comment has been minimized.

@seanyesmunt

seanyesmunt Jul 20, 2018

Member

Same here, use className="card__actions"

{__(
'Your wallet has been encrypted with a local password, performing this action will remove this password.'
)}
<FormRow padded>

This comment has been minimized.

@seanyesmunt

seanyesmunt Jul 20, 2018

Member

Shouldn't be a FormRow

};
}

updateStatus() {
Lbry.status().then(status => {
this._updateStatusCallback(status);
window.status = status;

This comment has been minimized.

@seanyesmunt

seanyesmunt Jul 20, 2018

Member

What does this do?

@lbry-bot lbry-bot assigned skhameneh and unassigned seanyesmunt Jul 20, 2018

Addressed comments

@skhameneh skhameneh requested a review from seanyesmunt Jul 25, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned skhameneh Jul 25, 2018

@lbry-bot lbry-bot assigned skhameneh and unassigned seanyesmunt Jul 25, 2018

seanyesmunt and others added some commits Jul 25, 2018

@skhameneh skhameneh merged commit 71bc347 into master Jul 25, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@seanyesmunt seanyesmunt deleted the wallet-encryption branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.