Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File viewer v2 #1826

Merged
merged 17 commits into from Aug 6, 2018

Conversation

Projects
None yet
5 participants
@btzr-io
Copy link
Collaborator

btzr-io commented Jul 27, 2018

Changes (WIP)

  • Closes: Better preview for content #620
  • Closes: Use router pattern for rendering file viewer (#1544)
  • Temp solution for: Add csv and json viewer (#1410)
  • Markdown viewer. (md, markdown)
  • Plain-text files and code snippets viewer (txt, json, csv, xml, log, yml).
  • Docx viewer (text only)
  • Html viewer. (iframe sandbox)
  • Implement syntax highlighter.
  • Fix description field fullscreen styles 77cfcc8.
  • Fix CodeMirror context menu be9c16c.
  • Choose a CodeMirror theme (light / dark).
  • Refactoring of fileSource logic.
  • Problem with search auto-complete menu when scrolling over file viewer #1847

Test

lbry://docxfile#a035152583aaa2ed50e6ab12174839a2cc2c0227

lbry://pdffile#1ec33dbcdf61c051b136354a9640f5dc25b04b96

lbry://csvfile#3eb2ae7de726f21318fc61c6794960f7fc4d81da

lbry://json#5fd9811240848eeae120166d8c57fc8e81dc6497

lbry://txtfile#13475689e84cd6c3ef43a279c0e8bfa6ed5c312f

lbry://index#6e477eded9468613c9c5b45eb58662ea302bccea

lbry://mdfile#24e737e03df62930ac4bd44151c818b3933a0381

bry://javascriptfile#c286d02c447aecb9cbd83b6f3ee6811e8fcc3d68

btzr-io added some commits Jul 26, 2018

add document viewer
- fix markdown viewer

- fix txt viewer
@skhameneh

This comment has been minimized.

Copy link
Member

skhameneh commented Jul 27, 2018

Looks good, nice work!
I'll need to take a closer look and test this out; @seanyesmunt also had some MD changes as well that I need to test and check for conflicts.

btzr-io added some commits Jul 27, 2018

@btzr-io

This comment has been minimized.

Copy link
Collaborator Author

btzr-io commented Jul 27, 2018

btzr-io added some commits Jul 28, 2018

@btzr-io btzr-io changed the title Document viewer File viewer Jul 28, 2018

@btzr-io btzr-io changed the title File viewer File viewer v2 Jul 28, 2018

@btzr-io btzr-io requested a review from seanyesmunt Jul 28, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned skhameneh Jul 28, 2018

@btzr-io btzr-io requested a review from kauffj Jul 28, 2018

@btzr-io btzr-io requested review from skhameneh and removed request for kauffj Jul 28, 2018

@kauffj

This comment has been minimized.

Copy link
Member

kauffj commented Jul 30, 2018

FYI @btzr-io @seanyesmunt is on vacation until Wednesday

@seanyesmunt

This comment has been minimized.

Copy link
Member

seanyesmunt commented Aug 3, 2018

Will test this today

@seanyesmunt

This comment has been minimized.

Copy link
Member

seanyesmunt commented Aug 3, 2018

Just added this to test lbry://javascriptfile#c286d02c447aecb9cbd83b6f3ee6811e8fcc3d68

@seanyesmunt
Copy link
Member

seanyesmunt left a comment

This is so cool. 🙂

One minor comment. Can you add a changelog too? Then it's ready to be merged.

.document-viewer .markdown-preview {
height: 100%;
overflow: auto;
padding: 32px 16px;

This comment has been minimized.

@seanyesmunt

seanyesmunt Aug 3, 2018

Member

padding in this file should use the spacing variables

border-right: 1px solid var(--color-divider);
background: var(--color-bg-alt);
padding-right: 8px;
z-index: 3;

This comment has been minimized.

@seanyesmunt

seanyesmunt Aug 3, 2018

Member

Whoops forgot to add this comment. This z-index seems a little weird. Is it needed?

This comment has been minimized.

@btzr-io

btzr-io Aug 3, 2018

Author Collaborator

not sure let me check, probably not 👍

btzr-io added some commits Aug 3, 2018

@btzr-io

This comment has been minimized.

Copy link
Collaborator Author

btzr-io commented Aug 3, 2018

@seanyesmunt ok done 👍

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented Aug 3, 2018

On lbry://@jiggytom#e48d2b50501159034f68d53321f67b8aa5b1d771/epubfile - a non-supported file, I'm missing a view button. Not sure if it should still say view, but lbry://zipfile does and it's an unsupported file. This isn't related to this PR, but thought i'd mention it as we are touching that code.

Otherwise, I tested a bunch of the videos and things look good! Thanks again for the contribution @btzr-io !

@seanyesmunt seanyesmunt merged commit d83f480 into master Aug 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@btzr-io btzr-io deleted the fix-viewer branch Aug 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.