New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FAQ to Publish Form #1833

Merged
merged 3 commits into from Jul 30, 2018

Conversation

Projects
None yet
3 participants
@ykris45
Contributor

ykris45 commented Jul 30, 2018

Preview

image

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Jul 30, 2018

Member

Our should be lowercase. @seanyesmunt / @skhameneh what do you think about the wording/placement?

Member

tzarebczan commented Jul 30, 2018

Our should be lowercase. @seanyesmunt / @skhameneh what do you think about the wording/placement?

@skhameneh

Minor comments

{__('Recommended size: 800x450 (16:9)')}
</React.Fragment>
)}
<React.Fragment>

This comment has been minimized.

@skhameneh

skhameneh Jul 30, 2018

Member

Please fix the excess indentations (is your IDE set correctly?)

@skhameneh

skhameneh Jul 30, 2018

Member

Please fix the excess indentations (is your IDE set correctly?)

This comment has been minimized.

@ykris45

ykris45 Jul 30, 2018

Contributor

@skhameneh how to fix this excess indentation. i use pretier code formating and vs code

@ykris45

ykris45 Jul 30, 2018

Contributor

@skhameneh how to fix this excess indentation. i use pretier code formating and vs code

@@ -482,7 +489,7 @@ class PublishForm extends React.PureComponent<Props> {
!channel || channel === CHANNEL_ANONYMOUS || channel === CHANNEL_NEW
? ''
: `${channel}/`
}`}
}`}

This comment has been minimized.

@skhameneh

skhameneh Jul 30, 2018

Member

Remove excess indentation

@skhameneh

skhameneh Jul 30, 2018

Member

Remove excess indentation

This comment has been minimized.

@ykris45

ykris45 Jul 30, 2018

Contributor

on line 492 sir

@ykris45

ykris45 Jul 30, 2018

Contributor

on line 492 sir

This comment has been minimized.

@ykris45
@ykris45

ykris45 Jul 30, 2018

Contributor

@skhameneh skhameneh merged commit 26d73c6 into lbryio:master Jul 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ykris45

This comment has been minimized.

Show comment
Hide comment
@ykris45

ykris45 Jul 30, 2018

Contributor

@tzarebczan bingo

Contributor

ykris45 commented Jul 30, 2018

@tzarebczan bingo

@ykris45 ykris45 deleted the ykris45:patch-1 branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment