New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get recommended videos from search based on title #1845

Merged
merged 7 commits into from Aug 13, 2018

Conversation

Projects
None yet
3 participants
@seanyesmunt
Member

seanyesmunt commented Aug 2, 2018

screen shot 2018-08-07 at 1 13 57 am

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Aug 3, 2018

Member

3 things I noticed:

  1. the URL is missing from the search bar when you go into it the first time. It comes back the next time you re-enter.
  2. if you go into lbry://three - you get a suggestion for lbry://three#claimid (that matches the same claim id). Probably a vanity url issue .
  3. I noticed the play button black > green (takes about a second or two) - can we speed this up? Why does it happen at all?
Member

tzarebczan commented Aug 3, 2018

3 things I noticed:

  1. the URL is missing from the search bar when you go into it the first time. It comes back the next time you re-enter.
  2. if you go into lbry://three - you get a suggestion for lbry://three#claimid (that matches the same claim id). Probably a vanity url issue .
  3. I noticed the play button black > green (takes about a second or two) - can we speed this up? Why does it happen at all?
@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Aug 7, 2018

Member

@tzarebczan
issue 1 will be fixed with lbryio/lbry-redux#65
Still thinking about how I can fix issue 2
issue 3 seems to exist on previous versions. Nothing from this PR should mess with that (it is definitely a valid issue though)

Member

seanyesmunt commented Aug 7, 2018

@tzarebczan
issue 1 will be fixed with lbryio/lbry-redux#65
Still thinking about how I can fix issue 2
issue 3 seems to exist on previous versions. Nothing from this PR should mess with that (it is definitely a valid issue though)

@seanyesmunt seanyesmunt requested a review from skhameneh Aug 9, 2018

@lbry-bot lbry-bot assigned skhameneh and unassigned seanyesmunt Aug 9, 2018

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Aug 9, 2018

Member

@skhameneh This is ready for review. There are still two issues but I would like to get this merged now so we can get some more eyes on it since I changed a lot of styles across the app.

Known issues:

  • if you go into lbry://three - you get a suggestion for lbry://three#claimid (that matches the same claim id). Probably a vanity url issue .
  • lbryio/lighthouse#101
Member

seanyesmunt commented Aug 9, 2018

@skhameneh This is ready for review. There are still two issues but I would like to get this merged now so we can get some more eyes on it since I changed a lot of styles across the app.

Known issues:

  • if you go into lbry://three - you get a suggestion for lbry://three#claimid (that matches the same claim id). Probably a vanity url issue .
  • lbryio/lighthouse#101

@lbry-bot lbry-bot assigned seanyesmunt and unassigned skhameneh Aug 10, 2018

@seanyesmunt seanyesmunt merged commit 39b01b6 into master Aug 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@seanyesmunt seanyesmunt deleted the next-video branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment