New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear upgrade subscribed interval after declining #1857

Merged
merged 5 commits into from Aug 9, 2018

Conversation

Projects
None yet
4 participants
@doniyor2109
Contributor

doniyor2109 commented Aug 6, 2018

Closes #1747

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Aug 6, 2018

Member

@doniyor2109 thanks for for this PR, please see https://lbry.io/faq/tips if you are interested in a tip for your contribution!

Just looking at this by inspection, it may prevent new upgrade modals from popping up if the user clicked decline, but I don't think it prevents multiple upgrade modals from stacking on each other if a user has the app running in the background and an update occurs.

Member

tzarebczan commented Aug 6, 2018

@doniyor2109 thanks for for this PR, please see https://lbry.io/faq/tips if you are interested in a tip for your contribution!

Just looking at this by inspection, it may prevent new upgrade modals from popping up if the user clicked decline, but I don't think it prevents multiple upgrade modals from stacking on each other if a user has the app running in the background and an update occurs.

Turn off timer after update downloads
This might do the trick, needs to be tested.

@tzarebczan tzarebczan requested a review from seanyesmunt Aug 7, 2018

@lbry-bot lbry-bot assigned seanyesmunt and unassigned seanyesmunt Aug 7, 2018

@doniyor2109

This comment has been minimized.

Show comment
Hide comment
@doniyor2109

doniyor2109 Aug 7, 2018

Contributor

@tzarebczan How can I create new action for app actions?

Contributor

doniyor2109 commented Aug 7, 2018

@tzarebczan How can I create new action for app actions?

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Aug 7, 2018

Member

@doniyor2109 i just submitted a commit which should fix this issue, but haven't tested it yet. I'll let @seanyesmunt review first.

Member

tzarebczan commented Aug 7, 2018

@doniyor2109 i just submitted a commit which should fix this issue, but haven't tested it yet. I'll let @seanyesmunt review first.

@doniyor2109

This comment has been minimized.

Show comment
Hide comment
@doniyor2109
Contributor

doniyor2109 commented Aug 7, 2018

Code refactor
Create action for clearing upgrade timer
@doniyor2109

This comment has been minimized.

Show comment
Hide comment
@doniyor2109

doniyor2109 Aug 7, 2018

Contributor

@tzarebczan Can you merge lbryio/lbry-redux#66 and upgrade lbry-redux?

Contributor

doniyor2109 commented Aug 7, 2018

@tzarebczan Can you merge lbryio/lbry-redux#66 and upgrade lbry-redux?

@alyssaoc alyssaoc added this to the Aug 20th (Protocol) milestone Aug 7, 2018

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Aug 9, 2018

Member

@doniyor2109 Looks good. I merged the lbry-redux PR and bumped the version in this PR. I'll give it a better test tomorrow before merging. Thanks for the contribution!

Member

seanyesmunt commented Aug 9, 2018

@doniyor2109 Looks good. I merged the lbry-redux PR and bumped the version in this PR. I'll give it a better test tomorrow before merging. Thanks for the contribution!

@seanyesmunt seanyesmunt merged commit f62181d into lbryio:master Aug 9, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Aug 9, 2018

Member

Thanks again @doniyor2109, was able to test and it worked!

Member

tzarebczan commented Aug 9, 2018

Thanks again @doniyor2109, was able to test and it worked!

@doniyor2109

This comment has been minimized.

Show comment
Hide comment
@doniyor2109

doniyor2109 Aug 10, 2018

Contributor

@tzarebczan I am glad to help 👌

Contributor

doniyor2109 commented Aug 10, 2018

@tzarebczan I am glad to help 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment