Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update electron to 2.0.6 #1858

Merged
merged 3 commits into from Aug 8, 2018

Conversation

Projects
None yet
2 participants
@tzarebczan
Copy link
Member

tzarebczan commented Aug 6, 2018

Also includes fix from electron/electron#13008 (comment)

Tested on Windows/Mac/Linux, don't see any issues. We'll revisit electron 3 when they are out of beta.

@seanyesmunt

This comment has been minimized.

Copy link
Member

seanyesmunt commented Aug 8, 2018

I am seeing

Electron Security Warning (Node.js Integration with Remote Content)

in the devtools. Do we need to make any changes to how we create the browser window?

@seanyesmunt seanyesmunt assigned tzarebczan and unassigned seanyesmunt Aug 8, 2018

@tzarebczan

This comment has been minimized.

Copy link
Member Author

tzarebczan commented Aug 8, 2018

@seanyesmunt should be fixed now!

tzarebczan and others added some commits Aug 6, 2018

disable dev mode security warnings
+ yarn lock update for 2.0.6 (it was already the version resolved previously)

@seanyesmunt seanyesmunt force-pushed the electron-2.0.6 branch from 2814a88 to d15585e Aug 8, 2018

@seanyesmunt seanyesmunt merged commit 10481a7 into master Aug 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@seanyesmunt seanyesmunt deleted the electron-2.0.6 branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.