Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the app directory via an absolute path instead of a relative one. #547

Merged
merged 2 commits into from Sep 11, 2017

Conversation

Projects
None yet
2 participants
@gyroninja
Copy link
Contributor

gyroninja commented Sep 10, 2017

In the internationalization code it is assumed that the app directory is in the current working directory.
This causes problems when the current working directory is not where it is expected. Before some of the internationalization code was temporarily disabled (a return was inserted at the begging of the doDownloadLanguages function), on startup it would get stuck and display a pure cyan screen. In the background it would start the daemon and everything, but it would not display anything but the cyan background. This was reported by me in #516.
This PR proposes that instead of assuming that the app folder for the application is in our current working directory, we grab the path of the app folder directly from Electron itself. We grab this directory by using Electron's remote module, which is made to be used by the render thread, to grab an instance of the Electron app object to get the path that we need.

@tzarebczan tzarebczan requested a review from lyoshenka Sep 11, 2017

@lyoshenka lyoshenka requested review from kauffj and removed request for lyoshenka Sep 11, 2017

@kauffj kauffj merged commit 78db4b0 into lbryio:master Sep 11, 2017

@kauffj

This comment has been minimized.

Copy link
Member

kauffj commented Sep 11, 2017

Thanks @gyroninja! Please DM @kauffj in our Slack or email jeremy@lbry.io if you'd like a tip for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.