New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on settings page on development #865

Merged
merged 6 commits into from Dec 12, 2017

Conversation

Projects
None yet
3 participants
@IGassmann
Contributor

IGassmann commented Dec 12, 2017

Fix settings page's error and apply some minor changes:

  • Enforce engine versions
  • Update path for prettier
  • Rename electron processes' entry points to avoid confusion with the main process.
  • Change node version to 8.x for supporting Ubuntu 17.10

@IGassmann IGassmann self-assigned this Dec 12, 2017

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Dec 12, 2017

Member

Why the changes to prettier? I updated the path last night. We should be using it in the /main process too. I also took it out of the "scripts" block because it was causing issues on precommit.

I think you accidentally moved the precommit: lint-staged script under bugs.

Member

seanyesmunt commented Dec 12, 2017

Why the changes to prettier? I updated the path last night. We should be using it in the /main process too. I also took it out of the "scripts" block because it was causing issues on precommit.

I think you accidentally moved the precommit: lint-staged script under bugs.

@IGassmann

This comment has been minimized.

Show comment
Hide comment
@IGassmann

IGassmann Dec 12, 2017

Contributor

@seanyesmunt I messed up that on the merge conflict. I'm rolling back the merge commit and doing it again.

Contributor

IGassmann commented Dec 12, 2017

@seanyesmunt I messed up that on the merge conflict. I'm rolling back the merge commit and doing it again.

@liamcardenas liamcardenas merged commit 839835e into master Dec 12, 2017

2 checks passed

Linux (LBRY App) TeamCity build finished
Details
OSX (LBRY App) TeamCity build finished
Details

@lyoshenka lyoshenka deleted the issue/839 branch Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment