New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup ESLint and Prettier and apply changes to sources #891

Merged
merged 22 commits into from Dec 27, 2017

Conversation

Projects
None yet
3 participants
@IGassmann
Contributor

IGassmann commented Dec 22, 2017

This configures ESLint and Prettier for the project and ensures they don't conflict with each other.

It also does:

  • Lint and consequently refactor all non-component source files
  • Pretty-print all sources
  • Add the commands yarn lint and yarn pretty-print
  • Rename command yarn dist to yarn build
  • Configure ESLint and Prettier to be compliant with Airbnb JavaScript Style Guide
  • Fix locales script
  • Warn if not using ES6 imports
  • Run Prettier and ESLint as a git hook for all staged files.

@IGassmann IGassmann requested a review from liamcardenas Dec 22, 2017

@IGassmann IGassmann self-assigned this Dec 22, 2017

@IGassmann IGassmann added the devops label Dec 22, 2017

@liamcardenas

Wow massive! this looks great. I'm not sure it's possible to code review every line here, instead maybe we should merge and do comprehensive testing to make sure everything still works. Thoughts @kauffj?

Igor Gassmann
@IGassmann

This comment has been minimized.

Show comment
Hide comment
@IGassmann

IGassmann Dec 26, 2017

Contributor

I've done some sanity testing on Windows and macOS.

Contributor

IGassmann commented Dec 26, 2017

I've done some sanity testing on Windows and macOS.

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Dec 26, 2017

Member

@liamcardenas I'm fine with this. @IGassmann are there any particular areas of concern?

Member

kauffj commented Dec 26, 2017

@liamcardenas I'm fine with this. @IGassmann are there any particular areas of concern?

@IGassmann

This comment has been minimized.

Show comment
Hide comment
@IGassmann

IGassmann Dec 26, 2017

Contributor

I've done some refactoring in pretty much all files with the exception of components files. With the tests, I identified (and fixed) only one bug due to my changes.

Contributor

IGassmann commented Dec 26, 2017

I've done some refactoring in pretty much all files with the exception of components files. With the tests, I identified (and fixed) only one bug due to my changes.

Igor Gassmann added some commits Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment