New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Electron linting errors #929

Merged
merged 14 commits into from Jan 15, 2018

Conversation

Projects
None yet
2 participants
@IGassmann
Contributor

IGassmann commented Jan 8, 2018

This pull request fixes #397 and:

  • Adds brew update to build script for getting latest dependencies versions
  • Cleans .gitignore to remove IDE specific ignores and old rules.
  • Renames package-json name field to be compliant with npm and yarn rules, and adds productName to build
  • Replaces dependency keytar with keytar-prebuild until atom/node-keytar#67 is not merged. This simplifies the build process on Windows. There's no need anymore for Python and Windows building tools.

@IGassmann IGassmann self-assigned this Jan 8, 2018

@IGassmann IGassmann requested a review from lyoshenka Jan 8, 2018

@lyoshenka

How much of build.sh can we put into yarn build. I'd love to drop that script, or at least work towards dropping it.

Show outdated Hide outdated build/install_deps.sh
Show outdated Hide outdated README.md
/src/main/locales
/src/main/node_modules
/src/renderer/dist
/build/venv

This comment has been minimized.

@lyoshenka

lyoshenka Jan 8, 2018

Member

i believe build/venv is still used (by build.sh)

@lyoshenka

lyoshenka Jan 8, 2018

Member

i believe build/venv is still used (by build.sh)

Show outdated Hide outdated .gitignore
/daemon/requirements.txt
/.idea
*.pyc

This comment has been minimized.

@lyoshenka

lyoshenka Jan 8, 2018

Member

this has to be here while upload_assets.py is still in use. if you want to rewrite that in JS instead, then we can drop python dependency completely, which would be sweet!

@lyoshenka

lyoshenka Jan 8, 2018

Member

this has to be here while upload_assets.py is still in use. if you want to rewrite that in JS instead, then we can drop python dependency completely, which would be sweet!

@IGassmann

This comment has been minimized.

Show comment
Hide comment
@IGassmann

IGassmann Jan 8, 2018

Contributor

build.sh is currently only necessary for downloading and extracting the daemon. I'm planning to try to get the daemon as a package.json dependency. It should be done with node-pre-gyp as far as I know.

Contributor

IGassmann commented Jan 8, 2018

build.sh is currently only necessary for downloading and extracting the daemon. I'm planning to try to get the daemon as a package.json dependency. It should be done with node-pre-gyp as far as I know.

@lyoshenka lyoshenka self-requested a review Jan 10, 2018

@lbry-bot lbry-bot assigned lyoshenka and unassigned IGassmann Jan 10, 2018

@lyoshenka

This comment has been minimized.

Show comment
Hide comment
@lyoshenka

lyoshenka Jan 10, 2018

Member

is the app no longer built/released by teamcity? teamcity runs build.sh

Member

lyoshenka commented Jan 10, 2018

is the app no longer built/released by teamcity? teamcity runs build.sh

@lbry-bot lbry-bot assigned lyoshenka and IGassmann and unassigned lyoshenka Jan 10, 2018

@lyoshenka

i hope you tested this on all 3 oses, and made sure it still works with teamcity. if so, lgtm

Show outdated Hide outdated package.json

@lbry-bot lbry-bot assigned IGassmann and unassigned IGassmann Jan 10, 2018

@lbry-bot lbry-bot assigned IGassmann and unassigned IGassmann Jan 15, 2018

@IGassmann IGassmann requested a review from lyoshenka Jan 15, 2018

@lbry-bot lbry-bot assigned lyoshenka and unassigned IGassmann Jan 15, 2018

@lyoshenka

make sure you change the app name back to lbry. otherwise lgtm.

@lbry-bot lbry-bot assigned IGassmann and unassigned lyoshenka Jan 15, 2018

Igor Gassmann

@IGassmann IGassmann merged commit 3c1d471 into master Jan 15, 2018

2 checks passed

Linux (LBRY App) TeamCity build finished
Details
OSX (LBRY App) TeamCity build finished
Details

@IGassmann IGassmann deleted the issue/397 branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment