Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce build dir / dist dir option for isolated build environments. #933

Merged
merged 1 commit into from Jan 9, 2018

Conversation

Projects
None yet
4 participants
@JoshStrobl
Copy link
Contributor

JoshStrobl commented Jan 9, 2018

This PR re-introduces the functionality for building lbry-app with a directory target. This is important for isolated build environments like solbuild (used for Solus), where build and install directories are different (and the contents of install dir are used in a final binary package) and thus necessitate being able to have unpackaged assets be placed in a directory relative to the build location, so instructions may be performed on those assets.

Note: This patch has already been tested with this commit to our package repo and validated locally.

Re-introduce build dir / dist dir option for isolated build environme…
…nts.

This commit re-introduces the functionality for building lbry-app with a directory target. This is important for isolated build environments like solbuild, where build and install directories are different (and the contents of install dir are used in a final binary package) and thus necessitate being able to have unpackaged assets be placed in a directory relative to the build location, so instructions may be performed on those assets.

@kauffj kauffj requested a review from IGassmann Jan 9, 2018

@IGassmann IGassmann merged commit 431c155 into lbryio:master Jan 9, 2018

@IGassmann

This comment has been minimized.

Copy link
Contributor

IGassmann commented Jan 9, 2018

@JoshStrobl Thanks for your contribution! Check out this for redeeming a reward.

@kauffj

This comment has been minimized.

Copy link
Member

kauffj commented Jan 9, 2018

@IGassmann it helps if you actually include the link 😛 https://lbry.io/faq/tips

But @JoshStrobl is a LBRY pro by now so I suspect he already knows he can get a reward for this. Thank you Josh!

@JoshStrobl

This comment has been minimized.

Copy link
Contributor Author

JoshStrobl commented Jan 9, 2018

Thanks for the quick review and merge @IGassmann. In terms of rewards, I'll pass (but it is appreciated). The patch was admittedly mostly self-serving, helps simplify the packaging process for the lbry-app on Solus and enables me to get it into the hands of users faster 😄

@JoshStrobl JoshStrobl deleted the JoshStrobl:readd-builddir branch Jan 9, 2018

JoshStrobl referenced this pull request Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.