Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC - issue #246 #257

Closed
ghost opened this issue Nov 29, 2017 · 2 comments
Closed

RFC - issue #246 #257

ghost opened this issue Nov 29, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 29, 2017

Source
image
This displays perfectly in fullscreen (via f11) however feels redundant considering it creates a scroll in of itself by including a footer. Would you stylistically appreciate the single page layout? If you highlight the image and note how it perfectly fills all of the screen space without leaving room for the browser components.

@ghost
Copy link
Author

ghost commented Nov 29, 2017

Would i be going too far out on a limb calling the footer header and leaving it on the bottom?

@lyoshenka
Copy link
Member

good point. I removed the footer. thanks for pointing this out. take a look at https://lbry.io/faq/tips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant