ported lbrynet.extras.daemon.analytics to asyncio
#1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@osilkin98 can you rebase/squash this down to one or two commits on top of master? |
osilkin98
force-pushed
the
asyncio-analytics
branch
2 times, most recently
from
eb20647
to
57375a5
Compare
|
@osilkin98 please let me know when this is done and ready for review, i'll likely have some comments |
osilkin98
force-pushed
the
asyncio-analytics
branch
from
57375a5
to
24b9263
Compare
Codecov Report
@@ Coverage Diff @@
## master #1745 +/- ##
==========================================
- Coverage 63.84% 63.82% -0.02%
==========================================
Files 150 150
Lines 13656 13641 -15
==========================================
- Hits 8718 8707 -11
+ Misses 4938 4934 -4
Continue to review full report at Codecov.
|
with `asyncio` and `aiohttp`. Also removes the calling loop from the analytics in favor of a `dict` that stores the names of the methods and their coroutines that are wrapped inside a looping task. The tasks are canceled when the analytics manager is asked to shutdown Signed-off-by: Oleg Silkin <o.silkin98@gmail.com>
Signed-off-by: Oleg Silkin <o.silkin98@gmail.com>
eukreign
force-pushed
the
asyncio-analytics
branch
from
ac2c8fa
to
badb2ff
Compare
eukreign
changed the title
lbrynet.extras.daemon.analytics to asyncio
eukreign
added
type: refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
This removes the use of
treqandtwistedmodules from being used inanalytics.py. It also removes the oldLoopingCallmechanism and replaces its manager component with adictthat stores the looping Tasks as aname -> Taskkey value pair, which makes use of thelooping_callfunction fromlbrynet.extras.daemon.storage.py. Modification is also made to thelooping_callfunction in order to catch the task cancellation error when being wrapped as a task coroutine.Instead of
treq, theaiohttplibrary is used, although instead of creating aClientSessionobject, I use theaiohttp.requestContextManager to set theApi's cookies as that of the response's.Why is this change necessary?
To remove the godawful dependency that is
twisted