Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stream_update failing on metadata only updates for files we don't have #2107

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
1 participant
@jackrobison
Copy link
Member

commented May 10, 2019

No description provided.

jackrobison added some commits May 10, 2019

only save the content claim if stream_hash isn't None
-stream_hash being none means we don't have the file in the database

@jackrobison jackrobison force-pushed the fix-update-file-we-dont-have branch from 3639c18 to 1a182bc May 10, 2019

@codecov

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #2107 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2107      +/-   ##
==========================================
- Coverage   78.18%   78.16%   -0.02%     
==========================================
  Files          96       96              
  Lines       10823    10824       +1     
==========================================
- Hits         8462     8461       -1     
- Misses       2361     2363       +2
Impacted Files Coverage Δ
lbrynet/extras/daemon/storage.py 81.86% <ø> (ø) ⬆️
lbrynet/extras/daemon/Daemon.py 76.29% <100%> (+0.01%) ⬆️
lbrynet/blob/writer.py 92.59% <0%> (-3.71%) ⬇️
lbrynet/blob/blob_file.py 91.85% <0%> (-0.91%) ⬇️
lbrynet/stream/reflector/server.py 78.51% <0%> (-0.83%) ⬇️
lbrynet/blob_exchange/client.py 75.28% <0%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0c0ee...1a182bc. Read the comment docs.

@jackrobison jackrobison merged commit 7d2f592 into master May 10, 2019

4 checks passed

codecov/patch 100% of diff hit (target 78.18%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +21.81% compared to 6c0c0ee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jackrobison jackrobison deleted the fix-update-file-we-dont-have branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.